Same with https://pinpoint-dot-chromeperf.appspot.com/job/14c437d6540000

These are caused by None's appearing in the result_values. Poking through a bit, the histograms themselves have null sample values: https://chrome-isolated.appspot.com/browse?namespace=default-gzip&digest=8af95fbd2bf9b875f3d915ec105ba2fab3dafc6e&as=perf_results.json


+benjhayden

Ben, are histograms allowed to have null sample values?

Yes
https://github.com/catapult-project/catapult/blob/master/tracing/tracing/value/histogram.html#L476

Fix out for review:
https://chromium-review.googlesource.com/c/catapult/+/1424217

However, this particular null might be related to another bug where mergeSampledStreams() could be sneaking undefined into its results.
https://bugs.chromium.org/p/chromium/issues/detail?id=923125#c4

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/43bcb969261ea67140c2cceb54bb4d91da20d18a

commit 43bcb969261ea67140c2cceb54bb4d91da20d18a
Author: Simon <simonhatch@chromium.org>
Date: Mon Jan 21 21:37:35 2019

Pinpoint - Typecheck sample values in pinpoint/models/job_state.

Histograms are currently allowed to store non-numeric sampleValues.
This should really be deserializing the Histograms and getting their average
using the API, but it looks like that would require more significant changes.

This is taking over benjhayden's cl from here: https://chromium-review.googlesource.com/c/catapult/+/1424217

Bug:  chromium:923509 
Change-Id: I9a2425af4a7b43894384c9a5861eb17ddbf9688c
Reviewed-on: https://chromium-review.googlesource.com/c/1425780
Reviewed-by: Ben Hayden <benjhayden@chromium.org>
Commit-Queue: Simon Hatch <simonhatch@chromium.org>

[modify] https://crrev.com/43bcb969261ea67140c2cceb54bb4d91da20d18a/dashboard/dashboard/pinpoint/models/job_state_test.py
[modify] https://crrev.com/43bcb969261ea67140c2cceb54bb4d91da20d18a/dashboard/dashboard/pinpoint/models/job.py
[modify] https://crrev.com/43bcb969261ea67140c2cceb54bb4d91da20d18a/dashboard/dashboard/pinpoint/models/job_state.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81574fb2e0c8fedbff34248fb4e91bc9660ecfb2

commit 81574fb2e0c8fedbff34248fb4e91bc9660ecfb2
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Mon Jan 21 23:55:19 2019

Roll src/third_party/catapult 39e1df9e9df0..43bcb969261e (1 commits)

https://chromium.googlesource.com/catapult.git/+log/39e1df9e9df0..43bcb969261e


git log 39e1df9e9df0..43bcb969261e --date=short --no-merges --format='%ad %ae %s'
2019-01-21 simonhatch@chromium.org Pinpoint - Typecheck sample values in pinpoint/models/job_state.


Created with:
  gclient setdep -r src/third_party/catapult@43bcb969261e

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:923509 
TBR=sullivan@chromium.org

Change-Id: Ie7758d13c0c2057ea75137398a44543c66270a07
Reviewed-on: https://chromium-review.googlesource.com/c/1426137
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#624693}
[modify] https://crrev.com/81574fb2e0c8fedbff34248fb4e91bc9660ecfb2/DEPS

These now load.