New issue
Advanced search Search tips

Issue 923492 link

Starred by 2 users
Status: Started
Owner:
stonebraker@chromium.org
Cc:
changwan@chromium.org
scottmg@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Missing gn tutorial files

Project Member Reported by stonebraker@chromium.org, Jan 18 (4 days ago) 
What steps will reproduce the problem?
(1) search for the tutorial files referenced here: https://gn.googlesource.com/gn/+/master/docs/quick_start.md
(2)
(3)

What is the expected result?
They are found in an appropriate repo

What happens instead?
They do not exist since they were removed from the chromium repo

Tutorial files were removed in the following cl: https://chromium-review.googlesource.com/c/chromium/src/+/1129822

per conversation with scottmg@chromium.org, adding tutorial files to gn repo is ideal but requires a gn toolchain setup (more work), so adding the files back to the chromium repo is a temporary fix.

Quick start guide will be updated to reference this fix: https://crbug.com/gn/41
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 18 (4 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c2ba6e3a5a648810a4eb83f3dcb2ebdf182d6b6

commit 3c2ba6e3a5a648810a4eb83f3dcb2ebdf182d6b6
Author: Drew Stonebraker <stonebraker@chromium.org>
Date: Fri Jan 18 21:30:25 2019

Add tutorial files for gn quick_start guide

Adding tutorial files referenced in
https://gn.googlesource.com/gn/+/master/docs/quick_start.md .
This is a temporary fix, as the tutorial files should ideally
live in the gn repo, but that repo does not yet have a gn
toolchain setup. I will be updating gn/docs/quick_start.md to
reference the location of these files.

Bug: 923492
Change-Id: I07b6429142a00ab4e3481aa9cbc354fc86694f1d
Reviewed-on: https://chromium-review.googlesource.com/c/1422526
Auto-Submit: Drew Stonebraker <stonebraker@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624291}
[add] https://crrev.com/3c2ba6e3a5a648810a4eb83f3dcb2ebdf182d6b6/tools/gn/tutorial/hello.cc
[add] https://crrev.com/3c2ba6e3a5a648810a4eb83f3dcb2ebdf182d6b6/tools/gn/tutorial/hello.h
[add] https://crrev.com/3c2ba6e3a5a648810a4eb83f3dcb2ebdf182d6b6/tools/gn/tutorial/hello_world.cc
[add] https://crrev.com/3c2ba6e3a5a648810a4eb83f3dcb2ebdf182d6b6/tools/gn/tutorial/say_hello.cc
►

Sign in to add a comment