New issue
Advanced search Search tips

Issue 923476 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug

Blocking:
issue 783777



Sign in to add a comment

Move session restoration out of TabModel

Project Member Reported by rohitrao@chromium.org, Jan 18 (4 days ago)

Issue description

We'd like to get rid of TabModel in favor of WebStateList, and one major function of TabModel is session restoration.  This code will need to move out of TabModel into somewhere else, perhaps attached to Browser.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Today (18 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d9f6c3d376172588e66b104f9495cdccb149dfd

commit 0d9f6c3d376172588e66b104f9495cdccb149dfd
Author: Rohit Rao <rohitrao@chromium.org>
Date: Tue Jan 22 11:29:35 2019

[ios] Moves session restoration out of the TabModel constructor.

TabModel's constructor used to take a SessionWindow as its first
argument, and it used that to populate the WebStateList with an initial
set of tabs.  The restoration happened at the end of the constructor,
however, making it easy to move the session restoration into another
function.  Callers that used to pass a non-nil SessionWindow now call
-[TabModel restoreSessionWindow:forInitialRestore:] immediately after
construction.

BUG=923476

Change-Id: I89b0406e7c68563a803fbef082fbd2ecf98abdd0
Reviewed-on: https://chromium-review.googlesource.com/c/1422959
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624760}
[modify] https://crrev.com/0d9f6c3d376172588e66b104f9495cdccb149dfd/ios/chrome/browser/crash_report/crash_restore_helper.mm
[modify] https://crrev.com/0d9f6c3d376172588e66b104f9495cdccb149dfd/ios/chrome/browser/sessions/session_window_restoring.h
[modify] https://crrev.com/0d9f6c3d376172588e66b104f9495cdccb149dfd/ios/chrome/browser/tabs/tab_model.h
[modify] https://crrev.com/0d9f6c3d376172588e66b104f9495cdccb149dfd/ios/chrome/browser/tabs/tab_model.mm
[modify] https://crrev.com/0d9f6c3d376172588e66b104f9495cdccb149dfd/ios/chrome/browser/tabs/tab_model_list_unittest.mm
[modify] https://crrev.com/0d9f6c3d376172588e66b104f9495cdccb149dfd/ios/chrome/browser/tabs/tab_model_unittest.mm
[modify] https://crrev.com/0d9f6c3d376172588e66b104f9495cdccb149dfd/ios/chrome/browser/test/perf_test_with_bvc_ios.mm
[modify] https://crrev.com/0d9f6c3d376172588e66b104f9495cdccb149dfd/ios/chrome/browser/ui/main/browser_view_wrangler.mm

Sign in to add a comment