New issue
Advanced search Search tips

Issue 923471 link

Starred by 1 user

Issue metadata

Status: Untriaged
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: Android , Chrome
Pri: 3
Type: Task


Show other hotlists

Hotlists containing this issue:
Translate-Fixit


Sign in to add a comment

Rework CanManuallyTranslate and InitiateManualTranslation.

Project Member Reported by frechette@chromium.org, Jan 18 (4 days ago)

Issue description

The `WhenReady` part of InitiateManualTranslation is redundant as we already check the necessary conditions in CanManuallyTranslate, i.e. c/1344256 makes c/1331688 redundant.

More people started used InitiateManualTranslationWhenReady, e.g. CustomTabPage (https://chromium-review.googlesource.com/c/chromium/src/+/1415263). They specifically need to trigger translate _when_ its ready, which is potentially an API we could expose in a better way then the bridge right now. For instance, they need to do custom state check (source != target) before translation, which we should support that better instead of having a custom translate function for each.
 

Comment 1 by frechette@chromium.org, Jan 18 (4 days ago)

Description: Show this description

Comment 2 by frechette@chromium.org, Today (10 hours ago)

Owner: ----

Sign in to add a comment