New issue
Advanced search Search tips

Issue 923464 link

Starred by 1 user
Status: Fixed
Owner:
robertogden@chromium.org
Closed: Today
Cc:
bengr@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

HTTPS previews may over-trigger when ECT is UNKNOWN

Project Member Reported by tbansal@chromium.org, Jan 18 (4 days ago) 
It seems that most (All?) of the previews do not trigger when ECT is UNKNOWN: https://cs.chromium.org/chromium/src/components/previews/content/previews_decider_impl.cc?rcl=13eb48b358edccb907b25692d74ecc9ffcc17237&l=491

However, Unknown ECT is not being checked for HTTPS server previews: https://cs.chromium.org/chromium/src/chrome/browser/previews/previews_lite_page_navigation_throttle.cc?rcl=13eb48b358edccb907b25692d74ecc9ffcc17237&l=276

We should add a check for UNKNOWN ECT in the HTTPS server previews triggering path, and record UMA around how frequently that happpens.
Project Member

Comment 1 by bugdroid1@chromium.org, Today (11 hours ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fb50d881c9336953cd52561e3b335df00e09d7c8

commit fb50d881c9336953cd52561e3b335df00e09d7c8
Author: Robert Ogden <robertogden@chromium.org>
Date: Tue Jan 22 19:17:11 2019

Add ECT Unknown checking to HTTPS Server Previews

This isn't being done in previews decider, so take of it in the
NavThrottle.

Bug:  923464 
Change-Id: I45b0f33e21ff54fc89b1a3ec79fa0fc5029c9c0a
Reviewed-on: https://chromium-review.googlesource.com/c/1423933
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624863}
[modify] https://crrev.com/fb50d881c9336953cd52561e3b335df00e09d7c8/chrome/browser/previews/previews_lite_page_browsertest.cc
[modify] https://crrev.com/fb50d881c9336953cd52561e3b335df00e09d7c8/chrome/browser/previews/previews_lite_page_navigation_throttle.cc
[modify] https://crrev.com/fb50d881c9336953cd52561e3b335df00e09d7c8/chrome/browser/previews/previews_lite_page_navigation_throttle.h
[modify] https://crrev.com/fb50d881c9336953cd52561e3b335df00e09d7c8/tools/metrics/histograms/enums.xml

Comment 2 by robertogden@chromium.org, Today (10 hours ago)

Status: Fixed (was: Assigned)
►

Sign in to add a comment