Auto-submit did not set CQ+2 via the reply dialog |
||||
Issue descriptionWhat steps will reproduce the problem? (1) Upload a change for review and turn on the "Auto-submit" tag from within the Gerrit UI: crrev.com/c/1415890 (2) Receive +1 from an owner What is the expected result? CQ process begins automatically What happens instead? Gerrit still shows the option to "Submit to CQ" and doesn't appear to have added Commit Bot to the CL.
,
Jan 18
(4 days ago)
The reviewer said they did not specifically uncheck the CQ+2.
,
Jan 18
(4 days ago)
+reviewer crouleau@ could you describe how you gave approval to https://chromium-review.googlesource.com/c/chromium/src/+/1415890 ? I know the Auto-Submit feature has been working: https://chromium-review.googlesource.com/q/label:Auto-Submit+repo:chromium/src+is:merged so maybe this was a timing issue.
,
Jan 18
(4 days ago)
I just hit LGTM and didn't do anything else.
,
Jan 18
(4 days ago)
There are 2 ways to give approval: The quick approve "Code-Review+1" button on the main page and via the "Reply" dialog popup. You hit the "Code-Review+1" button?
,
Jan 18
(4 days ago)
I think via the Reply dialog, but I'm not certain.
,
Jan 18
(4 days ago)
,
Jan 19
(4 days ago)
I would guess the reply dialog, that might be the only place there could be Gerrit lag while automatically setting the necessary votes. Please let us know if you see this happen again. Let's use this bug to dup against if there are similar reports. |
||||
►
Sign in to add a comment |
||||
Comment 1 by rmis...@google.com
, Jan 18 (4 days ago)