Use a version of cpplint.py that is maintained. |
|
Issue descriptionThe cpplint analyzer uses a version of cpplint fetched from elsewhere, in https://cs.chromium.org/chromium/infra/go/src/infra/tricium/functions/cpplint/Makefile. Currently it's https://github.com/google/styleguide/tree/gh-pages/cpplint BUT, as per the depot tools README: > Until 2018, our cpplint.py was a copy of the upstream version at https://github.com/google/styleguide/tree/gh-pages/cpplint. Unfortunately, that repository is not maintained any more. If you want to update cpplint.py in depot_tools, just upload a patch to do so. We should probably use the version in depot_tools rather than upstream, since there are no other better options: https://chromium.googlesource.com/chromium/tools/depot_tools.git/+/master/cpplint.py.
,
Jan 19
(4 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/depot_tools/+/f7971436824dd8eeb9b0cf19dabc3e32b369a904 commit f7971436824dd8eeb9b0cf19dabc3e32b369a904 Author: Quinten Yearsley <qyearsley@chromium.org> Date: Sat Jan 19 00:41:14 2019 Update depot_tools README cpplint section Context: https://chromium-review.googlesource.com/c/infra/infra/+/1422779 Bug: 923438 Change-Id: Ib433e219b45065ae5064aece921e710545e41b59 Reviewed-on: https://chromium-review.googlesource.com/c/1423377 Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> [modify] https://crrev.com/f7971436824dd8eeb9b0cf19dabc3e32b369a904/README.md
,
Jan 19
(4 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5758d433d22f78d7e73a8ad49318089097352d7c commit 5758d433d22f78d7e73a8ad49318089097352d7c Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Sat Jan 19 02:58:01 2019 Roll src/third_party/depot_tools cf032973e30c..f7971436824d (1 commits) https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/cf032973e30c..f7971436824d git log cf032973e30c..f7971436824d --date=short --no-merges --format='%ad %ae %s' 2019-01-19 qyearsley@chromium.org Update depot_tools README cpplint section Created with: gclient setdep -r src/third_party/depot_tools@f7971436824d The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:923438 TBR=agable@chromium.org Change-Id: I9a5035b8df7eec5d7d6e97c40d642f1421ff0a99 Reviewed-on: https://chromium-review.googlesource.com/c/1423658 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#624432} [modify] https://crrev.com/5758d433d22f78d7e73a8ad49318089097352d7c/DEPS |
|
►
Sign in to add a comment |
|
Comment 1 by bugdroid1@chromium.org
, Jan 18 (4 days ago)