New issue
Advanced search Search tips

Issue 923428 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Today
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug
Flaky-Test: WebAppPictureInPictureWindowControllerBrowserTest.AutoPictureInPictureWhenPictureInPictureWindowAlreadyVisible



Sign in to add a comment

WebAppPictureInPictureWindowControllerBrowserTest is flaky

Project Member Reported by Findit, Jan 18 (4 days ago)

Issue description

Comment 2 by gab@chromium.org, Jan 18 (4 days ago)

Owner: beaufort...@gmail.com
Status: Assigned (was: Untriaged)
Clearly caused by r624115 but the revert doesn't apply cleanly with r624017, r624125, and r624133 on top. Will disable test for now.

@Francois please address when you're back online.

Comment 3 by fbeaufort@chromium.org, Jan 18 (4 days ago)

Owner: fbeaufort@chromium.org
Status: Started (was: Assigned)
https://chromium-review.googlesource.com/c/chromium/src/+/1422920 should fix it.

Comment 4 by pnoland@chromium.org, Jan 18 (4 days ago)

Labels: -Sheriff-Chromium

Comment 5 by gab@chromium.org, Jan 18 (4 days ago)

 Issue 923529  has been merged into this issue.
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 18 (4 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63a9d4a9314680abbab05f4263c91cf31598e7ad

commit 63a9d4a9314680abbab05f4263c91cf31598e7ad
Author: Gabriel Charette <gab@chromium.org>
Date: Fri Jan 18 22:25:06 2019

Disable flaky WebAppPictureInPictureWindowControllerBrowserTest.AutoPictureInPictureWhenPictureInPictureWindowAlreadyVisible on Windows

crrev.com/624115 is at fault but it's behind a stack of 3 other CLs and
thus hard to revert. Let the owners try to fix and re-enable the test
instead of reverting everything.

TBR=beaufort.francois@gmail.com, haraken@chromium.org, mlamouri@chromium.org

Bug:  923428 
Change-Id: I6ffe0728cca31f1924085b22c90307557ccd44bb
Reviewed-on: https://chromium-review.googlesource.com/c/1422382
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#624322}
[modify] https://crrev.com/63a9d4a9314680abbab05f4263c91cf31598e7ad/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Jan 18 (4 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d86aa3d6a8bdd4a93541fe6eb46f35322664fd64

commit d86aa3d6a8bdd4a93541fe6eb46f35322664fd64
Author: Gabriel Charette <gab@chromium.org>
Date: Fri Jan 18 23:48:31 2019

Disable flaky WebAppPictureInPictureWindowControllerBrowserTest.AutoPictureInPicture

Findit spotted that this has the same issue as
WebAppPictureInPictureWindowControllerBrowserTest.AutoPictureInPictureWhenPictureInPictureWindowAlreadyVisible

TBR=beaufort.francois@gmail.com, haraken@chromium.org, mlamouri@chromium.org

Bug:  923428 
Change-Id: I5f95df17d0d5e912e09d7e8de1dd7a2dc82946e7
Reviewed-on: https://chromium-review.googlesource.com/c/1423419
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624359}
[modify] https://crrev.com/d86aa3d6a8bdd4a93541fe6eb46f35322664fd64/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc

Comment 8 by nhiroki@chromium.org, Jan 21 (2 days ago)

 Issue 923769  has been merged into this issue.

Comment 9 by nhiroki@chromium.org, Jan 21 (2 days ago)

 Issue 923641  has been merged into this issue.

Comment 10 by nhiroki@chromium.org, Jan 21 (2 days ago)

 Issue 923609  has been merged into this issue.

Comment 11 by nhiroki@chromium.org, Jan 21 (2 days ago)

Summary: WebAppPictureInPictureWindowControllerBrowserTest is flaky (was: WebAppPictureInPictureWindowControllerBrowserTest.AutoPictureInPictureWhenPictureInPictureWindowAlreadyVisible is flaky)
FindIt reported that these tests are also flaky from that change. See merged issues for FindIt's reports.

- WebAppPictureInPictureWindowControllerBrowserTest.AutoPictureInPictureNotTriggeredOnPageShownIfNoAttribute
- WebAppPictureInPictureWindowControllerBrowserTest.AutoPictureInPictureAttributeApplies
- WebAppPictureInPictureWindowControllerBrowserTest.AutoPictureInPictureNotTriggeredOnPageShownIfNotEnteredAutoPictureInPicture

Comment 12 by fbeaufort@chromium.org, Yesterday (45 hours ago)

Cc: mlamouri@chromium.org
Components: Blink>Media>PictureInPicture
Labels: OS-Chrome OS-Linux OS-Mac OS-Windows
WIP CL at https://chromium-review.googlesource.com/c/chromium/src/+/1422920
Project Member

Comment 13 by bugdroid1@chromium.org, Yesterday (37 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d026613b79fc6e3dbf6bcd3093922a461c21690e

commit d026613b79fc6e3dbf6bcd3093922a461c21690e
Author: François Beaufort <beaufort.francois@gmail.com>
Date: Mon Jan 21 16:27:28 2019

Fix flakyness in Picture-in-Picture browser tests.

Flakyness was caused by video not playing even though video.play() was
called. This CL makes sure test doesn't continue if video is not
actually playing.

Bug:  923428 
Change-Id: I43b814d32add8c8a423d9ad14a6fe494a02bc86a
Reviewed-on: https://chromium-review.googlesource.com/c/1422920
Auto-Submit: François Beaufort <beaufort.francois@gmail.com>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624601}
[modify] https://crrev.com/d026613b79fc6e3dbf6bcd3093922a461c21690e/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc
[modify] https://crrev.com/d026613b79fc6e3dbf6bcd3093922a461c21690e/chrome/test/data/extensions/auto_picture_in_picture/main.html

Comment 14 by fbeaufort@chromium.org, Today (21 hours ago)

Status: Fixed (was: Started)
I believe it's fixed according to https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20%2832%29%20Tests?limit=100.

Sign in to add a comment