Issue metadata
Sign in to add a comment
|
WebAppPictureInPictureWindowControllerBrowserTest is flaky |
||||||||||||||||||||||||
Issue descriptionFindit identified the culprit r624115 as introducing flaky test(s) summarized in https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZjA5ZTQ0NmU0YTVhOTA1ZTk3MjA3NGMyZmM0NzAwYTMxNTMzZjI1ZQw Please revert the culprit or disable the test(s) asap. If you are the owner, please fix! If the culprit above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20culprit%20r624115&comment=Link%20to%20Culprit%3A%20https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZjA5ZTQ0NmU0YTVhOTA1ZTk3MjA3NGMyZmM0NzAwYTMxNTMzZjI1ZQw Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
,
Jan 18
(4 days ago)
https://chromium-review.googlesource.com/c/chromium/src/+/1422920 should fix it.
,
Jan 18
(4 days ago)
,
Jan 18
(4 days ago)
Issue 923529 has been merged into this issue.
,
Jan 18
(4 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/63a9d4a9314680abbab05f4263c91cf31598e7ad commit 63a9d4a9314680abbab05f4263c91cf31598e7ad Author: Gabriel Charette <gab@chromium.org> Date: Fri Jan 18 22:25:06 2019 Disable flaky WebAppPictureInPictureWindowControllerBrowserTest.AutoPictureInPictureWhenPictureInPictureWindowAlreadyVisible on Windows crrev.com/624115 is at fault but it's behind a stack of 3 other CLs and thus hard to revert. Let the owners try to fix and re-enable the test instead of reverting everything. TBR=beaufort.francois@gmail.com, haraken@chromium.org, mlamouri@chromium.org Bug: 923428 Change-Id: I6ffe0728cca31f1924085b22c90307557ccd44bb Reviewed-on: https://chromium-review.googlesource.com/c/1422382 Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#624322} [modify] https://crrev.com/63a9d4a9314680abbab05f4263c91cf31598e7ad/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc
,
Jan 18
(4 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d86aa3d6a8bdd4a93541fe6eb46f35322664fd64 commit d86aa3d6a8bdd4a93541fe6eb46f35322664fd64 Author: Gabriel Charette <gab@chromium.org> Date: Fri Jan 18 23:48:31 2019 Disable flaky WebAppPictureInPictureWindowControllerBrowserTest.AutoPictureInPicture Findit spotted that this has the same issue as WebAppPictureInPictureWindowControllerBrowserTest.AutoPictureInPictureWhenPictureInPictureWindowAlreadyVisible TBR=beaufort.francois@gmail.com, haraken@chromium.org, mlamouri@chromium.org Bug: 923428 Change-Id: I5f95df17d0d5e912e09d7e8de1dd7a2dc82946e7 Reviewed-on: https://chromium-review.googlesource.com/c/1423419 Reviewed-by: Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#624359} [modify] https://crrev.com/d86aa3d6a8bdd4a93541fe6eb46f35322664fd64/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc
,
Jan 21
(2 days ago)
Issue 923769 has been merged into this issue.
,
Jan 21
(2 days ago)
Issue 923641 has been merged into this issue.
,
Jan 21
(2 days ago)
Issue 923609 has been merged into this issue.
,
Jan 21
(2 days ago)
FindIt reported that these tests are also flaky from that change. See merged issues for FindIt's reports. - WebAppPictureInPictureWindowControllerBrowserTest.AutoPictureInPictureNotTriggeredOnPageShownIfNoAttribute - WebAppPictureInPictureWindowControllerBrowserTest.AutoPictureInPictureAttributeApplies - WebAppPictureInPictureWindowControllerBrowserTest.AutoPictureInPictureNotTriggeredOnPageShownIfNotEnteredAutoPictureInPicture
,
Yesterday
(45 hours ago)
WIP CL at https://chromium-review.googlesource.com/c/chromium/src/+/1422920
,
Yesterday
(37 hours ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d026613b79fc6e3dbf6bcd3093922a461c21690e commit d026613b79fc6e3dbf6bcd3093922a461c21690e Author: François Beaufort <beaufort.francois@gmail.com> Date: Mon Jan 21 16:27:28 2019 Fix flakyness in Picture-in-Picture browser tests. Flakyness was caused by video not playing even though video.play() was called. This CL makes sure test doesn't continue if video is not actually playing. Bug: 923428 Change-Id: I43b814d32add8c8a423d9ad14a6fe494a02bc86a Reviewed-on: https://chromium-review.googlesource.com/c/1422920 Auto-Submit: François Beaufort <beaufort.francois@gmail.com> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#624601} [modify] https://crrev.com/d026613b79fc6e3dbf6bcd3093922a461c21690e/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc [modify] https://crrev.com/d026613b79fc6e3dbf6bcd3093922a461c21690e/chrome/test/data/extensions/auto_picture_in_picture/main.html
,
Today
(21 hours ago)
I believe it's fixed according to https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20%2832%29%20Tests?limit=100. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by Findit
, Jan 18 (4 days ago)