New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 923424 link

Starred by 1 user
Status: Started
Owner:
chanli@chromium.org
Cc:
no...@chromium.org
█ robert...@chromium.org
chanli@chromium.org
lijeffrey@chromium.org
liaoyuke@chromium.org
st...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Remove usage of swarming_tag tag prefix

Project Member Reported by no...@chromium.org, Jan 18 (4 days ago) 
FindIt currently extracts log_location from swarming_tag tag
https://cs.chromium.org/search/?q=swarming_tag%5Cb+-f:buildbucket&sq=package:chromium&type=cs

we need to remove swarming_tag tag, including log_location

Did find complete buildbucket v2 transition? go/build.proto has logdog project and prefix: Build.infra.logdog

Comment 1 by chanli@chromium.org, Jan 18 (4 days ago)

Owner: chanli@chromium.org
Status: Started (was: Untriaged)
That piece of code is obsolete. I'll remove it.
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 18 (4 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/246e7de4b72aa33a873b1ee408e2d212364882d4

commit 246e7de4b72aa33a873b1ee408e2d212364882d4
Author: Chan <chanli@chromium.org>
Date: Fri Jan 18 18:44:23 2019

[Findit] Remove obsolete GetLogLocationFromBuildbucketBuild from logdog_util.py

Bug: 923424
Change-Id: I2615ac8a2ab0e1a70151e6f5ab992063a585a583
Reviewed-on: https://chromium-review.googlesource.com/c/1422557
Reviewed-by: Shuotao Gao <stgao@chromium.org>
Commit-Queue: Shuotao Gao <stgao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#20079}
[modify] https://crrev.com/246e7de4b72aa33a873b1ee408e2d212364882d4/appengine/findit/infra_api_clients/logdog_util.py
[modify] https://crrev.com/246e7de4b72aa33a873b1ee408e2d212364882d4/appengine/findit/infra_api_clients/test/logdog_util_test.py
►

Sign in to add a comment