The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c8ba63e09c039082cf79b532ee820ab0f821472f

commit c8ba63e09c039082cf79b532ee820ab0f821472f
Author: Clark DuVall <cduvall@chromium.org>
Date: Fri Jan 18 17:57:13 2019

Disable ContextualSearchManagerTest#testTapCloseRemovedFromHistory

This test is failing regularly on multiple bots, see bug for details.

TBR=donnd@chromium.org

Bug: 923404
Change-Id: I39157e9e3e4c45c028df9714875ffba4c2960fe2
Reviewed-on: https://chromium-review.googlesource.com/c/1422238
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624191}
[modify] https://crrev.com/c8ba63e09c039082cf79b532ee820ab0f821472f/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java

From the failing range : https://chromium.googlesource.com/chromium/src/+log/1b9e2dda6a967f2b7d1591099046ec3d34de8498..bd7718be0193b4c1aa05260bac57d60a1c7760f7?pretty=fuller&n=10000

This is clearly caused by r622993 (or maybe by r622948 but my bet is strong on the first one given it touched the file of this very test).

Reverting culprits is much preferred to disabling tests so I'll do that and re-enable the test.

Failure log FTR:

================================================================================

java.lang.AssertionError: Panel did not enter CLOSED state. Instead, the current state is PEEKED.
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.assertTrue(Assert.java:41)
	at org.chromium.content_public.browser.test.util.CriteriaHelper.pollInstrumentationThread(CriteriaHelper.java:92)
	at org.chromium.content_public.browser.test.util.CriteriaHelper.pollUiThread(CriteriaHelper.java:171)
	at org.chromium.content_public.browser.test.util.CriteriaHelper.pollUiThread(CriteriaHelper.java:193)
	at org.chromium.chrome.browser.contextualsearch.ContextualSearchManagerTest.waitForPanelToEnterState(ContextualSearchManagerTest.java:822)
	at org.chromium.chrome.browser.contextualsearch.ContextualSearchManagerTest.waitForPanelToClose(ContextualSearchManagerTest.java:814)
	at org.chromium.chrome.browser.contextualsearch.ContextualSearchManagerTest.tapBasePageToClosePanel(ContextualSearchManagerTest.java:995)
	at org.chromium.chrome.browser.contextualsearch.ContextualSearchManagerTest.testTapCloseRemovedFromHistory(ContextualSearchManagerTest.java:2643)
	at java.lang.reflect.Method.invoke(Method.java)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:52)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.chromium.base.test.ScreenshotOnFailureStatement.evaluate(ScreenshotOnFailureStatement.java:41)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at org.chromium.chrome.test.ChromeActivityTestRule$1.evaluate(ChromeActivityTestRule.java:129)
	at org.junit.rules.TestWatcher$1.evaluate(TestWatcher.java:55)
	at android.support.test.internal.statement.UiThreadStatement.evaluate(UiThreadStatement.java:55)
	at android.support.test.rule.ActivityTestRule$ActivityStatement.evaluate(ActivityTestRule.java:270)
	at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
	at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
	at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:237)
	at org.chromium.base.test.BaseJUnit4ClassRunner.runChild(BaseJUnit4ClassRunner.java:48)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.chromium.base.test.CommitSharedPreferencesTestRule$1.evaluate(CommitSharedPreferencesTestRule.java:23)
	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.chromium.base.test.BaseJUnit4ClassRunner.run(BaseJUnit4ClassRunner.java:220)
	at org.junit.runners.Suite.runChild(Suite.java:128)
	at org.junit.runners.Suite.runChild(Suite.java:27)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:115)
	at android.support.test.internal.runner.TestExecutor.execute(TestExecutor.java:59)
	at android.support.test.runner.AndroidJUnitRunner.onStart(AndroidJUnitRunner.java:262)
	at org.chromium.base.test.BaseChromiumAndroidJUnitRunner.onStart(BaseChromiumAndroidJUnitRunner.java:128)
	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1879)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48cb4faa37f5b0a020021f17025850198fb6f8cc

commit 48cb4faa37f5b0a020021f17025850198fb6f8cc
Author: Gabriel Charette <gab@chromium.org>
Date: Fri Jan 18 20:36:45 2019

Revert "[TTS] Persist and resend event IDs for sawmill."

This reverts commit c845b226081b818a47fcdc33af8c689acbd41dad.

Reason for revert: strong suspect for crbug.com/923404

Original change's description:
> [TTS] Persist and resend event IDs for sawmill.
>
> Adds support for persisting and later reporting user interaction
> to the server in support of the offline sanitized click-log.
>
> BACKGROUND:
> This change allows the server to log outcomes from interactions and associate
> them with the privacy-safe documents in the Search Index. See go/cs-sanitized
> for more details on this design.
>
> DESIGN OVERVIEW:
> When the server recognizes a document it generates a random EventID and logs
> it to sawmill and returns it to the client in the response to the Resolve
> request.  The client passes the EventID up to Java and persists it in local
> device storage along with the user-interaction outcomes.  The next time
> the user makes a Resolve request the client checks for previous data, and if
> present it sends it as part of the Context to the server (and erases it
> from storage).
>
> DETAILS:
> This CL introduces a new interface ContextualSearchInteractionPersister to
> persist user interactions, and an implementation that uses local storage.
>
> The manager detects a new parameter for the EventID returned in the
> Resolve request. It stores this and an encoded set of bits that describe
> the user-interaction for that event in local storage.
> Any subsequent Resolve request checks for a previous EventID and when
> non-zero sends it along with the user-interaction results in CGI params
> to the server.  Support for these params on the client and server have
> already landed.
>
> If the server never sends an Event ID to log, then the client won't
> change it's behavior.  The server does not yet send these Event IDs.
>
> BUG=872902
>
> Change-Id: Ief9a95625b16a4b0a3be5325ed1adadff9c791b9
> Reviewed-on: https://chromium-review.googlesource.com/c/1170352
> Commit-Queue: Donn Denman <donnd@chromium.org>
> Reviewed-by: Brian White <bcwhite@chromium.org>
> Reviewed-by: Theresa <twellington@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#622993}

TBR=donnd@chromium.org,bcwhite@chromium.org,twellington@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 872902, 923404
Change-Id: I72d1d582bf1ab834c51af046204132d9c450e5ef
Reviewed-on: https://chromium-review.googlesource.com/c/1422897
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624264}
[modify] https://crrev.com/48cb4faa37f5b0a020021f17025850198fb6f8cc/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchContext.java
[delete] https://crrev.com/390c5bd29d37e2e88750dd2861bc1b289cdca55e/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchInteractionPersister.java
[delete] https://crrev.com/390c5bd29d37e2e88750dd2861bc1b289cdca55e/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchInteractionPersisterImpl.java
[modify] https://crrev.com/48cb4faa37f5b0a020021f17025850198fb6f8cc/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchInteractionRecorder.java
[modify] https://crrev.com/48cb4faa37f5b0a020021f17025850198fb6f8cc/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java
[modify] https://crrev.com/48cb4faa37f5b0a020021f17025850198fb6f8cc/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchNetworkCommunicator.java
[modify] https://crrev.com/48cb4faa37f5b0a020021f17025850198fb6f8cc/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchRankerLoggerImpl.java
[modify] https://crrev.com/48cb4faa37f5b0a020021f17025850198fb6f8cc/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchUma.java
[modify] https://crrev.com/48cb4faa37f5b0a020021f17025850198fb6f8cc/chrome/android/java/src/org/chromium/chrome/browser/preferences/ChromePreferenceManager.java
[modify] https://crrev.com/48cb4faa37f5b0a020021f17025850198fb6f8cc/chrome/android/java_sources.gni
[modify] https://crrev.com/48cb4faa37f5b0a020021f17025850198fb6f8cc/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchFakeServer.java
[modify] https://crrev.com/48cb4faa37f5b0a020021f17025850198fb6f8cc/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java
[modify] https://crrev.com/48cb4faa37f5b0a020021f17025850198fb6f8cc/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchTapEventTest.java
[modify] https://crrev.com/48cb4faa37f5b0a020021f17025850198fb6f8cc/chrome/android/junit/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchContextForTest.java
[modify] https://crrev.com/48cb4faa37f5b0a020021f17025850198fb6f8cc/chrome/android/junit/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchContextTest.java
[modify] https://crrev.com/48cb4faa37f5b0a020021f17025850198fb6f8cc/chrome/browser/android/contextualsearch/contextual_search_context.cc
[modify] https://crrev.com/48cb4faa37f5b0a020021f17025850198fb6f8cc/chrome/browser/android/contextualsearch/contextual_search_context.h
[modify] https://crrev.com/48cb4faa37f5b0a020021f17025850198fb6f8cc/chrome/browser/android/contextualsearch/contextual_search_delegate.cc
[modify] https://crrev.com/48cb4faa37f5b0a020021f17025850198fb6f8cc/chrome/browser/android/contextualsearch/contextual_search_delegate.h
[modify] https://crrev.com/48cb4faa37f5b0a020021f17025850198fb6f8cc/chrome/browser/android/contextualsearch/contextual_search_delegate_unittest.cc
[modify] https://crrev.com/48cb4faa37f5b0a020021f17025850198fb6f8cc/chrome/browser/android/contextualsearch/contextual_search_manager.cc
[modify] https://crrev.com/48cb4faa37f5b0a020021f17025850198fb6f8cc/chrome/browser/android/contextualsearch/resolved_search_term.cc
[modify] https://crrev.com/48cb4faa37f5b0a020021f17025850198fb6f8cc/chrome/browser/android/contextualsearch/resolved_search_term.h
[modify] https://crrev.com/48cb4faa37f5b0a020021f17025850198fb6f8cc/chrome/test/data/android/contextualsearch/tap_test.html
[modify] https://crrev.com/48cb4faa37f5b0a020021f17025850198fb6f8cc/tools/metrics/histograms/histograms.xml

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/21d9a5deadbc234fc9ebef60d29f7e77fb9c929f

commit 21d9a5deadbc234fc9ebef60d29f7e77fb9c929f
Author: Gabriel Charette <gab@chromium.org>
Date: Fri Jan 18 20:56:34 2019

Revert "Disable ContextualSearchManagerTest#testTapCloseRemovedFromHistory"

This reverts commit c8ba63e09c039082cf79b532ee820ab0f821472f.

Reason for revert: obvious culprit reverted, re-enabling test.

Original change's description:
> Disable ContextualSearchManagerTest#testTapCloseRemovedFromHistory
> 
> This test is failing regularly on multiple bots, see bug for details.
> 
> TBR=donnd@chromium.org
> 
> Bug: 923404
> Change-Id: I39157e9e3e4c45c028df9714875ffba4c2960fe2
> Reviewed-on: https://chromium-review.googlesource.com/c/1422238
> Reviewed-by: Clark DuVall <cduvall@chromium.org>
> Commit-Queue: Clark DuVall <cduvall@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#624191}

TBR=donnd@chromium.org,cduvall@chromium.org

Change-Id: Icece5808e43dc4b84261c58087b728591daf20ba
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 923404
Reviewed-on: https://chromium-review.googlesource.com/c/1422668
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624278}
[modify] https://crrev.com/21d9a5deadbc234fc9ebef60d29f7e77fb9c929f/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java