New issue
Advanced search Search tips

Issue 923399 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Today
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

angle_end2end_tests failing on chromium.gpu.fyi/Mac FYI GPU ASAN Release

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Jan 18 (4 days ago)

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of senorblanco@chromium.org

angle_end2end_tests failing on chromium.gpu.fyi/Mac FYI GPU ASAN Release

Builders failed on: 
- Mac FYI GPU ASAN Release: 
  https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac%20FYI%20GPU%20ASAN%20Release


 

Comment 1 by senorblanco@chromium.org, Jan 18 (4 days ago)

Cc: geoffl...@chromium.org
Components: Internals>GPU>ANGLE
Labels: Hotlist-PixelWrangler
It's failing GLSLTest_ES3.LargeNumberOfFloat4Parameters/ES3_OPENGL, but only on AMD and not Intel (used to be both, before something fixed it; perhaps the clobber that went through last night.

First less-red build: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac%20FYI%20GPU%20ASAN%20Release/3875

I'm guessing it might be an OOM issue, since it's somewhat flaky. Will followup with the ANGLE team. Thanks!

This test first started failing at 3860: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac%20FYI%20GPU%20ASAN%20Release/3860

Perhaps an out-of-memory issue.

Geoff, any ideas?

Comment 2 by geoffl...@chromium.org, Jan 18 (4 days ago)

Owner: cwallez@chromium.org
Corentin suppressed the failure on NVIDIA and Intel in https://chromium-review.googlesource.com/c/angle/angle/+/1419007 .  Looks like it needs the suppression on AMD too.

I'm guessing this is related to https://bugs.chromium.org/p/angleproject/issues/detail?id=3047 

Comment 3 by geoffl...@chromium.org, Jan 18 (4 days ago)

Corentin, could you suppress this on all mac?

Comment 4 by cwallez@chromium.org, Jan 18 (4 days ago)

Status: Started (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 18 (4 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/6ae34889cd8aaed571d0ba1dc4798477f0965ea9

commit 6ae34889cd8aaed571d0ba1dc4798477f0965ea9
Author: Corentin Wallez <cwallez@chromium.org>
Date: Fri Jan 18 20:18:07 2019

Suppress test crashing on Mac ASAN AMD too.

The initial suppression didn't apply to AMD but the test crashes there
too.

BUG=angleproject:3087
BUG= chromium:923399 

Change-Id: I8ccffbb7746dd6fc6aa3eb6edaaef30aaae8c097
Reviewed-on: https://chromium-review.googlesource.com/c/1423057
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>

[modify] https://crrev.com/6ae34889cd8aaed571d0ba1dc4798477f0965ea9/src/tests/gl_tests/GLSLTest.cpp

Project Member

Comment 6 by bugdroid1@chromium.org, Jan 18 (4 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/676d9edc224f346ecbb791e3846c09ddb5277801

commit 676d9edc224f346ecbb791e3846c09ddb5277801
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Fri Jan 18 23:31:22 2019

Roll src/third_party/angle 85ca71c2167b..6ae34889cd8a (1 commits)

https://chromium.googlesource.com/angle/angle.git/+log/85ca71c2167b..6ae34889cd8a


git log 85ca71c2167b..6ae34889cd8a --date=short --no-merges --format='%ad %ae %s'
2019-01-18 cwallez@chromium.org Suppress test crashing on Mac ASAN AMD too.


Created with:
  gclient setdep -r src/third_party/angle@6ae34889cd8a

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:923399 
TBR=cwallez@chromium.org

Change-Id: Ieac7f9ae198481edc4956183d40c1cef4147bdb1
Reviewed-on: https://chromium-review.googlesource.com/c/1423080
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#624350}
[modify] https://crrev.com/676d9edc224f346ecbb791e3846c09ddb5277801/DEPS

Comment 7 by senorblanco@chromium.org, Today (14 hours ago)

Status: Fixed (was: Started)
Looks like the ASAN bot has been green for 20+ runs. \o/

Sign in to add a comment