New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 923361 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac , Fuchsia
Pri: 3
Type: Feature



Sign in to add a comment

Rework Persistent API to allow integration with EmbedderHeapTracer

Project Member Reported by mlippautz@google.com, Jan 18 (4 days ago)

Issue description

Tracking bug for reworking the existing v8::Persistent API to allow better integration with v8::EmbedderHeapTracer. This includes e.g. not using a weak persistent as datatype for traced handles.
 

Comment 1 by mlippautz@google.com, Jan 18 (4 days ago)

Cc: haraken@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 18 (4 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/489d2a1888e4d00a780ed7d99d33cc3514082602

commit 489d2a1888e4d00a780ed7d99d33cc3514082602
Author: Michael Lippautz <mlippautz@chromium.org>
Date: Fri Jan 18 16:59:34 2019

[global-handles] Refactor to allow for different node type

- Introduce NodeSpace that holds allocation related logic.
- Provide std compatible iterator for node iteration.

This allows for creating a different internal node type.

The change is just a refactoring without functional changes.

Bug: chromium:923361
Change-Id: I424f821d96b3a82f64024aedff6c289d3eec11a2
Reviewed-on: https://chromium-review.googlesource.com/c/1418192
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58931}
[modify] https://crrev.com/489d2a1888e4d00a780ed7d99d33cc3514082602/src/global-handles.cc
[modify] https://crrev.com/489d2a1888e4d00a780ed7d99d33cc3514082602/src/global-handles.h

Project Member

Comment 4 by bugdroid1@chromium.org, Yesterday (34 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/0781f42b67cdcaf0d8246b95bb7a76d43b500a6f

commit 0781f42b67cdcaf0d8246b95bb7a76d43b500a6f
Author: Michael Lippautz <mlippautz@chromium.org>
Date: Mon Jan 21 19:50:04 2019

[global-handles] Deprecate unused methods

Bug: chromium:923361
Change-Id: I520b2778b8a2fe3fcd52570f3a91758bc949f374
Reviewed-on: https://chromium-review.googlesource.com/c/1425897
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58975}
[modify] https://crrev.com/0781f42b67cdcaf0d8246b95bb7a76d43b500a6f/include/v8.h
[modify] https://crrev.com/0781f42b67cdcaf0d8246b95bb7a76d43b500a6f/test/cctest/test-api.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Today (18 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/2b77aaf47c70b4c6621fc3bfcce87129120a7782

commit 2b77aaf47c70b4c6621fc3bfcce87129120a7782
Author: Michael Lippautz <mlippautz@chromium.org>
Date: Tue Jan 22 12:18:30 2019

[global-handles] Restructure GC post processing

Bug: chromium:923361
Change-Id: I97a0314b6d5af543e0574f27892c73637739844d
Reviewed-on: https://chromium-review.googlesource.com/c/1426124
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58984}
[modify] https://crrev.com/2b77aaf47c70b4c6621fc3bfcce87129120a7782/src/global-handles.cc
[modify] https://crrev.com/2b77aaf47c70b4c6621fc3bfcce87129120a7782/src/global-handles.h
[modify] https://crrev.com/2b77aaf47c70b4c6621fc3bfcce87129120a7782/src/heap/heap.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Today (17 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/5043ab267007b0c7f80bbce77d2295ce6b6d72c2

commit 5043ab267007b0c7f80bbce77d2295ce6b6d72c2
Author: Michael Lippautz <mlippautz@chromium.org>
Date: Tue Jan 22 12:56:41 2019

Revert "[global-handles] Restructure GC post processing"

This reverts commit 2b77aaf47c70b4c6621fc3bfcce87129120a7782.

Reason for revert: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux64%20-%20cfi/18836

Original change's description:
> [global-handles] Restructure GC post processing
> 
> Bug: chromium:923361
> Change-Id: I97a0314b6d5af543e0574f27892c73637739844d
> Reviewed-on: https://chromium-review.googlesource.com/c/1426124
> Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
> Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#58984}

TBR=ulan@chromium.org,mlippautz@chromium.org

Change-Id: I8220c60573cf7f4a1ced99bcd18628933c45f41e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: chromium:923361
Reviewed-on: https://chromium-review.googlesource.com/c/1425901
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58985}
[modify] https://crrev.com/5043ab267007b0c7f80bbce77d2295ce6b6d72c2/src/global-handles.cc
[modify] https://crrev.com/5043ab267007b0c7f80bbce77d2295ce6b6d72c2/src/global-handles.h
[modify] https://crrev.com/5043ab267007b0c7f80bbce77d2295ce6b6d72c2/src/heap/heap.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Today (15 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/62938a980e27f6669d07d43707b4a80254b3b90a

commit 62938a980e27f6669d07d43707b4a80254b3b90a
Author: Michael Lippautz <mlippautz@chromium.org>
Date: Tue Jan 22 14:38:02 2019

Reland "[global-handles] Restructure GC post processing"

This reverts commit 5043ab267007b0c7f80bbce77d2295ce6b6d72c2.

Tbr: ulan@chromium.org
Bug: chromium:923361
Change-Id: I3a2cf2c29fe4dc424def8dc086856ed3301f2fc2
Reviewed-on: https://chromium-review.googlesource.com/c/1425904
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58992}
[modify] https://crrev.com/62938a980e27f6669d07d43707b4a80254b3b90a/src/global-handles.cc
[modify] https://crrev.com/62938a980e27f6669d07d43707b4a80254b3b90a/src/global-handles.h
[modify] https://crrev.com/62938a980e27f6669d07d43707b4a80254b3b90a/src/heap/heap.cc

Project Member

Comment 8 by bugdroid1@chromium.org, Today (15 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/1fc43aa8891baa3d3afd7d921516a5461fd05c87

commit 1fc43aa8891baa3d3afd7d921516a5461fd05c87
Author: Michael Lippautz <mlippautz@chromium.org>
Date: Tue Jan 22 14:48:02 2019

[global-handles] Remove parallelization for minor MC

Reworking and adding a node type would require also adding
parallelization support for minor mc. Since this is unused and not
benchmarked right now, just remove it.

Bug: chromium:923361
Change-Id: Iaf67a743d76d2b37ffff9961b510bfd8a1bd15ff
Reviewed-on: https://chromium-review.googlesource.com/c/1425900
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#58993}
[modify] https://crrev.com/1fc43aa8891baa3d3afd7d921516a5461fd05c87/src/global-handles.cc
[modify] https://crrev.com/1fc43aa8891baa3d3afd7d921516a5461fd05c87/src/global-handles.h
[modify] https://crrev.com/1fc43aa8891baa3d3afd7d921516a5461fd05c87/src/heap/heap.cc
[modify] https://crrev.com/1fc43aa8891baa3d3afd7d921516a5461fd05c87/src/heap/mark-compact.cc

Sign in to add a comment