New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 923331 link

Starred by 1 user
Status: Fixed
Owner:
hungte@chromium.org
Closed: Jan 18
Cc:
█ apier@chromium.org
hungte@chromium.org
jclinton@chromium.org
adurbin@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Builder of factory-soraka-10323.39.B Got Failed in InitSDK Stage

Project Member Reported by marcochen@chromium.org, Jan 18 (4 days ago) 
build link - https://uberchromegw.corp.google.com/i/chromeos.branch/builders/soraka%20factory%20factory-soraka-10323.39.B/builds/27

Log of failed stage - https://logs.chromium.org/logs/chromeos/bb/chromeos.branch/soraka_factory_factory-soraka-10323.39.B/27/+/recipes/steps/InitSDK/0/stdout

Error msg:
  vboot_reference-1.0-r1448: In file included from futility/futility.c:18:0:
  vboot_reference-1.0-r1448: futility/futility.h:112:28: error: 'struct vb2_gbb_header' declared inside parameter list [-Werror]
  vboot_reference-1.0-r1448:  int vb2_change_hwid(struct vb2_gbb_header *gbb, const char *hwid);
  vboot_reference-1.0-r1448:                             ^
  vboot_reference-1.0-r1448: futility/futility.h:112:28: error: its scope is only this definition or declaration, which is probably not what you want [-Werror]
  vboot_reference-1.0-r1448:     CC            futility/cmd_sign.o

Comment 1 by marcochen@chromium.org, Jan 18 (4 days ago)

Cc: hungte@chromium.org

Comment 2 by marcochen@chromium.org, Jan 18 (4 days ago) 

cc hungte@,

It seems to be caused by the CL [1] merged 3 days ago.

[1] https://chromium.googlesource.com/chromiumos/platform/vboot_reference/+/2b48f519106f9373c5b48e8942c392a109bc77ac%5E%21/#F0

Comment 3 by hungte@chromium.org, Jan 18 (4 days ago)

Owner: hungte@chromium.org
Status: Started (was: Untriaged)
https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/1421579
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 18 (4 days ago)

Labels: merge-merged-factory-soraka-10323.39.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/vboot_reference/+/b861c14e3f19d712f76093309071873a5bef08b3

commit b861c14e3f19d712f76093309071873a5bef08b3
Author: Hung-Te Lin <hungte@chromium.org>
Date: Fri Jan 18 14:41:35 2019

futility: Fix build failure by missing struct declaration

The factory branch seem to not always include vb2 structures
so we have to declare directly in futility.h.

BUG= chromium:923331 
TEST=make futil -j

Change-Id: I4b4073244b034426544d8f4f1dd79a0c8c36b7e7
Reviewed-on: https://chromium-review.googlesource.com/c/1421579
Reviewed-by: Hung-Te Lin <hungte@chromium.org>
Commit-Queue: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Trybot-Ready: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/b861c14e3f19d712f76093309071873a5bef08b3/futility/futility.h
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 18 (4 days ago)

Labels: merge-merged-factory-coral-10122.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/vboot_reference/+/32729b5f7e9845d23fac82eb822a8166233f0b23

commit 32729b5f7e9845d23fac82eb822a8166233f0b23
Author: Hung-Te Lin <hungte@chromium.org>
Date: Fri Jan 18 14:51:05 2019

futility: Fix build failure by missing struct declaration

The factory branch seem to not always include vb2 structures
so we have to declare directly in futility.h.

BUG= chromium:923331 
TEST=make futil -j

Change-Id: I4b4073244b034426544d8f4f1dd79a0c8c36b7e7
Reviewed-on: https://chromium-review.googlesource.com/c/1421579
Reviewed-by: Hung-Te Lin <hungte@chromium.org>
Commit-Queue: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Trybot-Ready: Hung-Te Lin <hungte@chromium.org>
(cherry picked from commit b861c14e3f19d712f76093309071873a5bef08b3)
Reviewed-on: https://chromium-review.googlesource.com/c/1421582

[modify] https://crrev.com/32729b5f7e9845d23fac82eb822a8166233f0b23/futility/futility.h
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 18 (4 days ago)

Labels: merge-merged-factory-poppy-10504.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/vboot_reference/+/273ec0e7599db47e0ee947a71bd68a696d46f14c

commit 273ec0e7599db47e0ee947a71bd68a696d46f14c
Author: Hung-Te Lin <hungte@chromium.org>
Date: Fri Jan 18 14:51:07 2019

futility: Fix build failure by missing struct declaration

The factory branch seem to not always include vb2 structures
so we have to declare directly in futility.h.

BUG= chromium:923331 
TEST=make futil -j

Change-Id: I4b4073244b034426544d8f4f1dd79a0c8c36b7e7
Reviewed-on: https://chromium-review.googlesource.com/c/1421579
Reviewed-by: Hung-Te Lin <hungte@chromium.org>
Commit-Queue: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Trybot-Ready: Hung-Te Lin <hungte@chromium.org>
(cherry picked from commit b861c14e3f19d712f76093309071873a5bef08b3)
Reviewed-on: https://chromium-review.googlesource.com/c/1421580

[modify] https://crrev.com/273ec0e7599db47e0ee947a71bd68a696d46f14c/futility/futility.h
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 18 (4 days ago)

Labels: merge-merged-factory-fizz-10167.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/vboot_reference/+/6a23e16317c585612c3790a214a4b7f551bb7ed7

commit 6a23e16317c585612c3790a214a4b7f551bb7ed7
Author: Hung-Te Lin <hungte@chromium.org>
Date: Fri Jan 18 14:51:08 2019

futility: Fix build failure by missing struct declaration

The factory branch seem to not always include vb2 structures
so we have to declare directly in futility.h.

BUG= chromium:923331 
TEST=make futil -j

Change-Id: I4b4073244b034426544d8f4f1dd79a0c8c36b7e7
Reviewed-on: https://chromium-review.googlesource.com/c/1421579
Reviewed-by: Hung-Te Lin <hungte@chromium.org>
Commit-Queue: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Trybot-Ready: Hung-Te Lin <hungte@chromium.org>
(cherry picked from commit b861c14e3f19d712f76093309071873a5bef08b3)
Reviewed-on: https://chromium-review.googlesource.com/c/1421583

[modify] https://crrev.com/6a23e16317c585612c3790a214a4b7f551bb7ed7/futility/futility.h
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 18 (4 days ago)

Labels: merge-merged-factory-gru-9017.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/vboot_reference/+/6242935351fce4ac652293d6e4132471af67b462

commit 6242935351fce4ac652293d6e4132471af67b462
Author: Hung-Te Lin <hungte@chromium.org>
Date: Fri Jan 18 14:51:08 2019

futility: Fix build failure by missing struct declaration

The factory branch seem to not always include vb2 structures
so we have to declare directly in futility.h.

BUG= chromium:923331 
TEST=make futil -j

Change-Id: I4b4073244b034426544d8f4f1dd79a0c8c36b7e7
Reviewed-on: https://chromium-review.googlesource.com/c/1421579
Reviewed-by: Hung-Te Lin <hungte@chromium.org>
Commit-Queue: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Trybot-Ready: Hung-Te Lin <hungte@chromium.org>
(cherry picked from commit b861c14e3f19d712f76093309071873a5bef08b3)
Reviewed-on: https://chromium-review.googlesource.com/c/1421585

[modify] https://crrev.com/6242935351fce4ac652293d6e4132471af67b462/futility/futility.h
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 18 (4 days ago)

Labels: merge-merged-factory-scarlet-10211.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/vboot_reference/+/7cccc93463d9b83f8723bc85b1c3cf6d7e7c9840

commit 7cccc93463d9b83f8723bc85b1c3cf6d7e7c9840
Author: Hung-Te Lin <hungte@chromium.org>
Date: Fri Jan 18 14:51:09 2019

futility: Fix build failure by missing struct declaration

The factory branch seem to not always include vb2 structures
so we have to declare directly in futility.h.

BUG= chromium:923331 
TEST=make futil -j

Change-Id: I4b4073244b034426544d8f4f1dd79a0c8c36b7e7
Reviewed-on: https://chromium-review.googlesource.com/c/1421579
Reviewed-by: Hung-Te Lin <hungte@chromium.org>
Commit-Queue: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Trybot-Ready: Hung-Te Lin <hungte@chromium.org>
(cherry picked from commit b861c14e3f19d712f76093309071873a5bef08b3)
Reviewed-on: https://chromium-review.googlesource.com/c/1421581

[modify] https://crrev.com/7cccc93463d9b83f8723bc85b1c3cf6d7e7c9840/futility/futility.h
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 18 (4 days ago)

Labels: merge-merged-factory-eve-9667.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/vboot_reference/+/220f36c60471971badcb638586ca6f7062bf2547

commit 220f36c60471971badcb638586ca6f7062bf2547
Author: Hung-Te Lin <hungte@chromium.org>
Date: Fri Jan 18 14:51:10 2019

futility: Fix build failure by missing struct declaration

The factory branch seem to not always include vb2 structures
so we have to declare directly in futility.h.

BUG= chromium:923331 
TEST=make futil -j

Change-Id: I4b4073244b034426544d8f4f1dd79a0c8c36b7e7
Reviewed-on: https://chromium-review.googlesource.com/c/1421579
Reviewed-by: Hung-Te Lin <hungte@chromium.org>
Commit-Queue: Hung-Te Lin <hungte@chromium.org>
Tested-by: Hung-Te Lin <hungte@chromium.org>
Trybot-Ready: Hung-Te Lin <hungte@chromium.org>
(cherry picked from commit b861c14e3f19d712f76093309071873a5bef08b3)
Reviewed-on: https://chromium-review.googlesource.com/c/1421584

[modify] https://crrev.com/220f36c60471971badcb638586ca6f7062bf2547/futility/futility.h

Comment 11 by hungte@chromium.org, Jan 18 (4 days ago)

Status: Fixed (was: Started)
all factory branches fixed

Comment 12 by jclinton@chromium.org, Jan 18 (4 days ago)

Components: -Infra>ChromeOS>CI OS>Firmware
Labels: -Pri-3 Pri-1
►

Sign in to add a comment