New issue
Advanced search Search tips

Issue 923322 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 880841



Sign in to add a comment

Update AccountsInCookieJarInfo to use ListedAccount

Project Member Reported by lowell@chromium.org, Jan 18 (4 days ago)

Issue description

Right now it is using AccountInfo, but it should use ListedAccount instead.
 

Comment 1 by lowell@chromium.org, Jan 18 (4 days ago)

Blocking: 880841
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 18 (4 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b758f6fbeaae44da900169114087b0562da3f902

commit b758f6fbeaae44da900169114087b0562da3f902
Author: Lowell Manners <lowell@chromium.org>
Date: Fri Jan 18 16:41:13 2019

Update AccountsInCookieJarInfo to use ListedAccount.

This CL updates AccountsInCookieJarInfo to return lists of
ListedAccount, rather than lists of AccountInfo.

Before this CL, IdentityManager would convert ListedAccount objects from
the gaia cookie, into AccountInfo objects. This wasn't ideal, as
AccountInfo and ListedAccount represent different logical concepts, and
have non-overlapping fields.

Change-Id: I2182ad66aba7952a4145ea8ea3d382f275d61f86
Bug: 923322
Reviewed-on: https://chromium-review.googlesource.com/c/1421178
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Antonio Gomes <tonikitoo@igalia.com>
Commit-Queue: Lowell Manners <lowell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624160}
[modify] https://crrev.com/b758f6fbeaae44da900169114087b0562da3f902/chrome/browser/signin/signin_ui_util.cc
[modify] https://crrev.com/b758f6fbeaae44da900169114087b0562da3f902/components/signin/core/browser/account_investigator.cc
[modify] https://crrev.com/b758f6fbeaae44da900169114087b0562da3f902/components/signin/core/browser/account_investigator.h
[modify] https://crrev.com/b758f6fbeaae44da900169114087b0562da3f902/components/signin/core/browser/account_investigator_unittest.cc
[modify] https://crrev.com/b758f6fbeaae44da900169114087b0562da3f902/components/sync/driver/sync_auth_util.cc
[modify] https://crrev.com/b758f6fbeaae44da900169114087b0562da3f902/services/identity/public/cpp/accounts_in_cookie_jar_info.cc
[modify] https://crrev.com/b758f6fbeaae44da900169114087b0562da3f902/services/identity/public/cpp/accounts_in_cookie_jar_info.h
[modify] https://crrev.com/b758f6fbeaae44da900169114087b0562da3f902/services/identity/public/cpp/identity_manager.cc
[modify] https://crrev.com/b758f6fbeaae44da900169114087b0562da3f902/services/identity/public/cpp/identity_manager_unittest.cc

Sign in to add a comment