New issue
Advanced search Search tips

Issue 923290 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Selection highlight in omnibox appears only on a part of the URL on switching between tabs

Project Member Reported by vineet...@virtusa.com, Jan 18 (4 days ago)

Issue description

Chrome Version: 73.0.3674.0 (Official Build) Revision 69010a60db037ed7b973da72c8e4171434473102-refs/branch-heads/3674@{#1}(32/64 bit)
OS: Mac(10.13.1, 10.13.6, 10.14.3) ,Win (7,8,8.1,10), Linux(14.04 LTS)   

Steps to reproduce:
1. Launch chrome, open 2 tabs.
2. In the first tab navigate to a short URL for eg: chrome://welcome.
3. In the second tab navigate to a relatively longer URL for eg: https://permission.site.
4. In the second tab itself right click on the omnibox and click 'Cut' option from the context menu to cut the URL.
5. Now click on the first tab and the click back on the second tab and observe the selection highlight on the URL.

Actual Result   : Selection highlight in omnibox appears only on a part of the URL on switching between tabs.
Expected Result : Entire URL should appear selected in omnibox on switching between tabs.

This is a regression issue broken in M-72 and below is the per-revision bisect information:
Good Build : 72.0.3589.0 (Revision : 601811)
Bad Build  : 72.0.3590.0 (Revision : 602167)

You are probably looking for a change made after 601830 (known good), but no later than 601831 (first known bad).

CHANGE-LOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/17f4e7d2ec13d6112dfcd8aa253f340bdb00d395..c647b2ae93668cf14396d2835b6a28cd00f0de9c

Suspect: https://chromium.googlesource.com/chromium/src/+/c647b2ae93668cf14396d2835b6a28cd00f0de9c

@sangwoo.ko: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note: 
1. Issue is also seen on Beta #72.0.3626.64 and Dev #73.0.3673.0.

Kindly refer the attached screen cast.

Thank you
 
ActualVideo.mp4
550 KB View Download
ExpectedVideo.mp4
550 KB View Download

Comment 1 by sangwoo108@chromium.org, Today (20 hours ago)

Cc: erikc...@chromium.org
Thanks for reporting. Yes, this seems to be caused by my CL. But I'm not sure how to fix it. When we switch the active tab, we do 1) save omnibox states for old contents 2) and restore the states for the new one. In step 1) we revert texts(resets texts) if user editing text is empty. This means that selection is based on new contents' URL.

@Omnibox owners, could you help me with this?

Sign in to add a comment