New issue
Advanced search Search tips

Issue 923279 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Today
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

[LayoutNG] Negative right margin seems to shrink element down

Reported by volu...@gmail.com, Jan 18 (4 days ago)

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/71.0.3578.98 Safari/537.36

Steps to reproduce the problem:
1. Create an inline <div> with inline pseudo-element ::before
2. Set pseudo-element to fixed width and height
3. Set `margin-right: -100%`

See: https://codepen.io/anon/pen/oJrxOV

What is the expected behavior?
The element doesn't shrink down.

What went wrong?
Element shrinks down.

Did this work before? Yes 71.0.3578.98

Does this work in other browsers? Yes

Chrome version: 73.0.3674.0  Channel: canary
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version:
 
margin-bug.png
49.4 KB View Download

Comment 1 by woxxom@gmail.com, Jan 18 (4 days ago)

This is caused by a field trial flag being enabled on random installations of Canary so you can repro by force-enabling it:
chrome --enable-features=LayoutNG

Conversely, to disable the bug run chrome with "--disable-features=LayoutNG"

Bisected to r609030 = 1c8b66379cbaf6a358164e106351f70b3800514f = crrev.com/c/1323803 by ikilpatrick@chromium.org
"[LayoutNG] Introduce NGConstraintSpace::RareData."
Landed in 72.0.3613.0

Comment 2 by dtapu...@chromium.org, Jan 18 (4 days ago)

Components: Blink>Layout

Comment 3 by susan.boorgula@chromium.org, Jan 20 (2 days ago)

Labels: Needs-Triage-M73 Needs-Bisect

Comment 4 by e...@chromium.org, Jan 21 (2 days ago)

Labels: LayoutNG
Owner: ikilpatrick@chromium.org
Status: Assigned (was: Unconfirmed)
Summary: [LayoutNG] Negative right margin seems to shrink element down (was: Negative right margin seems to shrink element down)

Comment 5 by santhoshkumar@chromium.org, Yesterday (42 hours ago)

Cc: santhoshkumar@chromium.org
Labels: -Pri-2 ReleaseBlock-Stable RegressedIn-72 Triaged-ET FoundIn-73 Target-72 Target-73 M-72 FoundIn-72 hasbisect OS-Linux OS-Mac Pri-1
Able to reproduce the issue on reported chrome stable #73.0.3674.0  and latest chrome version #73.0.3678.0 by using Windows 7, Ubuntu 17.10 and Mac OS 10.14 by following steps as per comment#0. 

Bisect Information:
===============
Good build: 72.0.3612.0
Bad build: 72.0.3613.0
From comment #1 Confirming Suspect: https://chromium.googlesource.com/chromium/src/+/1c8b66379cbaf6a358164e106351f70b3800514f
Reviewed-on: https://chromium-review.googlesource.com/c/1323803
@Ian: Please help us in reassigning the issue if it is not related to your change.Adding Release-Block-Stable label as it is recent regression.Please feel free to remove if it is not applicable
Thanks.!

Comment 6 by gov...@chromium.org, Yesterday (27 hours ago)

Cc: kgna...@chromium.org candr...@chromium.org
Labels: OS-Android OS-Chrome
As this is Blink, tentatively applying Android and Chrome OS as well. 

+ candrada@ & kgnaidu@, requesting to repro on live M72 beta build #72.0.3626.64
on Android.


Reminder M72 Stable is coming soon. Please review this bug and assess if this is indeed a RBS. If not, please remove the RBS label. If so, please make sure to land the fix and request a merge into the release branch ASAP. Thank you.

Comment 7 by ikilpatrick@chromium.org, Today (13 hours ago)

Labels: -ReleaseBlock-Stable
removing release block stable as this is only related to the LayoutNG experiemnt which is not enabled by default yet.

Comment 8 by candr...@chromium.org, Today (12 hours ago)

Cc: prashanthpola@chromium.org
prashanthpola@, can you please check on Android?  Thanks.
Project Member

Comment 9 by bugdroid, Today (9 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/081ceeb2f119bb9779582a6cc2e04d79efdb61b1

commit 081ceeb2f119bb9779582a6cc2e04d79efdb61b1
Author: Ian Kilpatrick <ikilpatrick@chromium.org>
Date: Tue Jan 22 20:58:46 2019

[LayoutNG] Fix min/max size of atomic inlines with -ve margins.

We were resolving %-margins during the min/max phase against
LayoutUnit::Max().

This was bad.

Now we explicitly set the percentage resolution sizes to zero.

Bug:  923279 
Change-Id: I619cef6ee2e4c18ad3a9bc213442a9a63a515e87
Reviewed-on: https://chromium-review.googlesource.com/c/1427539
Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624909}
[modify] https://crrev.com/081ceeb2f119bb9779582a6cc2e04d79efdb61b1/third_party/blink/renderer/core/layout/ng/inline/ng_inline_node.cc
[add] https://crrev.com/081ceeb2f119bb9779582a6cc2e04d79efdb61b1/third_party/blink/web_tests/external/wpt/css/CSS2/normal-flow/intrinsic-size-with-negative-margins.html

Comment 10 by prashanthpola@chromium.org, Today (8 hours ago)

We are not able to repro this issue on Android Chrome:73.0.3680.0 and  Device:Samsung Galaxy S7 EDGE (SM-G935T)/8.0.0 and Samsung Galaxy Note 3 Neo(SM-N750)/LMY47X.

Note:
We are able to repro this issue on Android Chrome:73.0.3680.0 Device:Samsung Galaxy S7 EDGE (SM-G935T)/8.0.0 and Samsung Galaxy Note 3 Neo(SM-N750)/LMY47X after Enabling the flag "Enable LayoutNG" from Chrome://flags

Comment 11 by prashanthpola@chromium.org, Today (8 hours ago)

Sorry ignore C#10

We are not able to repro this issue on Android Chrome:73.0.3680.0 and 72.0.3626.64 Device:Samsung Galaxy S7 EDGE (SM-G935T)/8.0.0 and Samsung Galaxy Note 3 Neo(SM-N750)/LMY47X.

Note:
We are able to repro this issue on Android Chrome:73.0.3680.0 and 72.0.3626.64 Device:Samsung Galaxy S7 EDGE (SM-G935T)/8.0.0 and Samsung Galaxy Note 3 Neo(SM-N750)/LMY47X after Enabling the flag "Enable LayoutNG" from Chrome://flags

Comment 12 by ikilpatrick@chromium.org, Today (7 hours ago)

Status: Fixed (was: Assigned)

Sign in to add a comment