New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 923275 link

Starred by 1 user
Status: Verified
Owner:
tikuta@chromium.org
Closed: Jan 18
Cc:
j...@chromium.org
flyboy@chromium.org
rauch+monorail-auto@google.com
█ orodley+autocc@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 914264



Sign in to add a comment

'compile confirm no-op' check does not pass on codesearch-gen-chromium-android builder

Project Member Reported by tikuta@chromium.org, Jan 18 (4 days ago) 
The step started to complain from
https://ci.chromium.org/p/infra/builders/luci.infra.codesearch/codesearch-gen-chromium-android/3928
```
ninja explain: output gen/base/base_java__lint/config.xml doesn't exist
ninja explain: gen/base/base_java__lint/result.xml is dirty
ninja explain: gen/base/base_java__lint/config.xml is dirty
ninja explain: obj/base/base_java__lint.stamp is dirty
ninja explain: output gen/base/base_java_test_support__lint/config.xml doesn't exist
ninja explain: gen/base/base_java_test_support__lint/result.xml is dirty
ninja explain: gen/base/base_java_test_support__lint/config.xml is dirty
ninja explain: obj/base/base_java_test_support__lint.stamp is dirty
ninja explain: output gen/ui/android/ui_full_java__lint/config.xml doesn't exist
ninja explain: gen/ui/android/ui_full_java__lint/result.xml is dirty
ninja explain: gen/ui/android/ui_full_java__lint/config.xml is dirty
ninja explain: obj/ui/android/ui_full_java__lint.stamp is dirty
......
```

I tried to reproduce locally, but couldn't.
Also there is no suspicious change in chromium/src around that time.

So I'm now suspecting that there is some infra specific issue.
Do we have some process that tried to remove file in build directory?

Comment 1 by tikuta@chromium.org, Jan 18 (4 days ago)

Owner: tikuta@chromium.org
Status: Started (was: Untriaged)
I logged into swarm1882-c4 and confirmed that following command is not no-op in the builder.


chrome-bot@swarm1882-c4:(Linux 14.04):/b/swarming/w/ir/cache/builder/src$ /b/swarming/w/ir/kitchen-checkout/depot_tools/ninja -C out/android-Debug/ -d explain -v gen/net/android/net_java__lint/config.xml 
ninja: Entering directory `out/android-Debug/'
ninja explain: output gen/net/android/net_java__lint/config.xml doesn't exist
[1/1] python ../../build/android/gyp/lint.py --lint-path ../../third_party/android_tools/sdk/tools-lint/bin/lint --cache-dir android_lint_cache --platform-xml-path ../../third_party/android_tools/sdk/platform-tools/api/api-versions.xml --android-sdk-version=26 --depfile gen/net/android/net_java__lint.d --config-path ../../build/android/lint/suppressions.xml --product-dir=. --processed-config-path gen/net/android/net_java__lint/config.xml --result-path gen/net/android/net_java__lint/result.xml --include-unexpected-failures --java-sources-file=gen/net/android/net_java.sources --srcjars=@FileArg\(gen/net/android/net_java.build_config:gradle:bundled_srcjars\) --can-fail-build --resource-sources=@FileArg\(gen/net/android/net_java.build_config:deps_info:owned_resources_dirs\) --resource-sources=@FileArg\(gen/net/android/net_java.build_config:deps_info:owned_resources_zips\)
chrome-bot@swarm1882-c4:(Linux 14.04):/b/swarming/w/ir/cache/builder/src$ /b/swarming/w/ir/kitchen-checkout/depot_tools/ninja -C out/android-Debug/ -d explain -v gen/net/android/net_java__lint/config.xml 
ninja: Entering directory `out/android-Debug/'
ninja explain: output gen/net/android/net_java__lint/config.xml doesn't exist
[1/1] python ../../build/android/gyp/lint.py --lint-path ../../third_party/android_tools/sdk/tools-lint/bin/lint --cache-dir android_lint_cache --platform-xml-path ../../third_party/android_tools/sdk/platform-tools/api/api-versions.xml --android-sdk-version=26 --depfile gen/net/android/net_java__lint.d --config-path ../../build/android/lint/suppressions.xml --product-dir=. --processed-config-path gen/net/android/net_java__lint/config.xml --result-path gen/net/android/net_java__lint/result.xml --include-unexpected-failures --java-sources-file=gen/net/android/net_java.sources --srcjars=@FileArg\(gen/net/android/net_java.build_config:gradle:bundled_srcjars\) --can-fail-build --resource-sources=@FileArg\(gen/net/android/net_java.build_config:deps_info:owned_resources_dirs\) --resource-sources=@FileArg\(gen/net/android/net_java.build_config:deps_info:owned_resources_zips\)

Comment 2 by tikuta@chromium.org, Jan 18 (4 days ago) 

And I confirmed that following command does not generate gen/net/android/net_java__lint/config.xml in my local.

~/chromium/src/out/codesearch-gen-chromium-android$ python ../../build/android/gyp/lint.py --lint-path ../../third_party/android_tools/sdk/tools-lint/bin/lint --cache-dir android_lint_cache --platform-xml-path ../../third_party/android_tools/sdk/platform-tools/api/api-versions.xml --android-sdk-version=26 --depfile gen/net/android/net_java__lint.d --config-path ../../build/android/lint/suppressions.xml --product-dir=. --processed-config-path gen/net/android/net_java__lint/config.xml --result-path gen/net/android/net_java__lint/result.xml --include-unexpected-failures --java-sources-file=gen/net/android/net_java.sources --srcjars=@FileArg\(gen/net/android/net_java.build_config:gradle:bundled_srcjars\) --can-fail-build --resource-sources=@FileArg\(gen/net/android/net_java.build_config:deps_info:owned_resources_dirs\) --resource-sources=@FileArg\(gen/net/android/net_java.build_config:deps_info:owned_resources_zips\)
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 18 (4 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2b5e4afadc58ee44f1889dc5f41cef70f63bb89

commit e2b5e4afadc58ee44f1889dc5f41cef70f63bb89
Author: Takuto Ikuta <tikuta@chromium.org>
Date: Fri Jan 18 15:26:49 2019

[build] fix missing outputs file of android lint

When we already have result.xml but config.xml is accidentally removed case,
lint.py does not generates config.xml.

Let me tell lint.py that config.xml is output of execution too.

Bug:  923275 
Change-Id: I9c556cb235aa1411debf7c9d8cf5ad67d00590a4
Reviewed-on: https://chromium-review.googlesource.com/c/1420638
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624131}
[modify] https://crrev.com/e2b5e4afadc58ee44f1889dc5f41cef70f63bb89/build/android/gyp/lint.py

Comment 4 by jbudorick@chromium.org, Jan 18 (4 days ago)

Cc: -bpastene@chromium.org -sergeybe...@google.com -martiniss@chromium.org -jbudorick@chromium.org j...@chromium.org
Components: -Infra>Client>Chrome Infra>Codesearch
►

Sign in to add a comment