New issue
Advanced search Search tips

Issue 923272 link

Starred by 1 user
Status: Fixed
Owner:
dbeam@chromium.org
Closed: Jan 18
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
hcarmona@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Reset button on chrome://settingsis seen enabled on tap-touch.

Project Member Reported by aim...@virtusa.com, Jan 18 (4 days ago) 
Chrome Version: 73.0.3674.0 (Official Build) 69010a60db037ed7b973da72c8e4171434473102-refs/branch-heads/3674@{#1} (32/64-bit)

OS: Windows 10 (Touch Device).

Steps to reproduce:
1. Launch chrome, Navigate to chrome://settings/reset
2. Tap touch on 'Restore settings to their original defaults' option
3. Now, tap-touch on 'Reset Setting' button.
4. Observe.

Actual Result: Reset button is still seen enabled (with dark blue background) on tap-touching.

Expected Result: Reset button should be disabled when tap-touched to reset the browser.

This is Regression Issue broken in M-73, and below is the per-revision bisect info.
Good Build : 73.0.3667.0 (Revision:621407)  
Bad Build : 73.0.3668.0 (Revision:621859)

You are probably looking for a change made after 621698 (known good), but no later than 621699 (first known bad).

CHANGE-LOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/9afafd8fa37175cd36bf01c8f272c39a75d2e1f8..c77fae33781b6c45947bc22e114a76c69f677924

Suspect: https://chromium.googlesource.com/chromium/src/+/c77fae33781b6c45947bc22e114a76c69f677924

@dbeam:Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note:
1. Issue is Win 10 (Touch Device) specific and is not seen on Win(7,8,8.1,10), Mac(10.13.1,10.13.6,10.14.3) and Linux(14.04 LTS) OS.
2. Issue is also seen on Dev #72.0.3673.0 build.

Kindly refer the attached screen-cast.

Thank You!
Actual Result.mp4
721 KB View Download
Expected Result.mp4
735 KB View Download

Comment 1 by dbeam@chromium.org, Jan 18 (4 days ago)

Status: Started (was: Assigned)

Comment 2 by dbeam@chromium.org, Jan 18 (4 days ago)

Cc: hcarmona@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 18 (4 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1211d4d3fd9b00ae6a4edc1067ff48342762aedd

commit 1211d4d3fd9b00ae6a4edc1067ff48342762aedd
Author: Dan Beam <dbeam@chromium.org>
Date: Fri Jan 18 21:13:12 2019

Fix touch-specific primary paper-button background regression

It seems like on touch screens, a button stays :active even when it
becomes [disabled] (but not with mouse).

This is an uncommon situation, but does happen on dialogs to prevent
accidentally performing the dialogs primary action twice (i.e. reset
profile).

In https://crrev.com/c/1402347, I upped the specificity of a rule that
wasn't working so it started taking an effect. But I didn't up
specificity of other rules, specifically primary disable buttons. This
fixes that.

R=hcarmona@chromium.org
BUG= 923272 

Change-Id: Idcc34c694f23b66a84ce1ccce429d491f56150fd
Reviewed-on: https://chromium-review.googlesource.com/c/1422584
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624283}
[modify] https://crrev.com/1211d4d3fd9b00ae6a4edc1067ff48342762aedd/ui/webui/resources/cr_elements/paper_button_style_css.html

Comment 4 by dbeam@chromium.org, Jan 18 (4 days ago)

Status: Fixed (was: Started)

Comment 5 by aim...@virtusa.com, Yesterday (45 hours ago)

Labels: TE-Verified-M73 TE-Verified-73.0.3679.0
Hi,

Retested the above issue on Win-10 Touch device using latest Canary build #73.0.3679.0 and issue is fixed.

Kindly view the screen-cast attached below.

Thank You!
Canary Behaviour.mp4
767 KB View Download
►

Sign in to add a comment