New issue
Advanced search Search tips

Issue 923261 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

FrameHader in H264/VP8/VP9Picture need not be pointer

Project Member Reported by hiroh@chromium.org, Jan 18 (4 days ago)

Issue description

VP8Picture's default constructor allocates Vp9FrameHeader by "new".
https://cs.chromium.org/chromium/src/media/gpu/vp8_picture.cc?l=9&rcl=8041a078908d455d239ddd7d76aab1c28145dbbe

Thereafter, the actual variable is copied in VP8Encoder, but just replaced by VP8Decoder.
https://cs.chromium.org/chromium/src/media/gpu/vaapi/vp8_encoder.cc?l=111&rcl=7656904f6e89b6fe8c0f3f3aa9afd56fe1b9b073
https://cs.chromium.org/chromium/src/media/gpu/vp8_decoder.cc?l=152&rcl=8041a078908d455d239ddd7d76aab1c28145dbbe

I think the same thing can be said for H264 and VP9 Picture.

H264/VP8/VP9Picture don't manage any resource. They should be just a variable, not pointer.
 

Sign in to add a comment