New issue
Advanced search Search tips

Issue 923256 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Clean up Previews.ServerLitePage. timing histograms

Project Member Reported by robertogden@google.com, Jan 18 (4 days ago)

Issue description

Description for "Previews.ServerLitePage.HttpOnlyFallbackPenalty" says: This does not include any penalty incurred because of network errors but there is not a histogram for the converse

Previews.ServerLitePage.NotReportedNavigationRestartPenalty should be marked obsolete. It's code is missing (rushed crash fix) and it never got taken care of in histograms.xml

Previews.ServerLitePage.ReportedNavigationRestartPenalty should be marked obsolete. It's code is missing (rushed crash fix) and it never got taken care of in histograms.xml
 

Comment 1 by tbansal@chromium.org, Jan 18 (4 days ago)

Cc: tombergan@chromium.org
Labels: OS-Android
Currently, it seems the penalty seems high (https://screenshot.googleplex.com/K8Nethdqbxj). We also have a histogram of different server responses (https://screenshot.googleplex.com/1a3kKk6Rw15).

I think at some point we would need to work on reducing this penalty. I would suggest adding more histograms to better understand the penalty (may be split by server response?).

Additionally, we need to add histogram to track penalty incurred because of network errors. I would also suggest recording the net errors encountered when trying to fetch the lite page (e.g, net::ABORTED vs. net::SERVER_UNREACHABLE etc.).

Sign in to add a comment