New issue
Advanced search Search tips

Issue 923229 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 919414



Sign in to add a comment

SignedExchange: Implement Variants check

Project Member Reported by ksakamoto@chromium.org, Jan 18 (5 days ago)

Issue description

Tracks Chromium-side work for https://github.com/WICG/webpackage/pull/360

- Update our structured header parser to draft-ietf-httpbis-header-structure-09
  - Support "List of Lists" parsing
  - Characters allowed in identifier (now called Token) are expanded.
    - This is necessary to allow header field names as tokens
- Implement the "Request matching" algorithm [1]
  - Determine which content negotiation mechanisms we support
    - [2] defines Accept, Accept-Encoding, Accept-Language. Probably Accept-Encoding doesn't make much sense in SXG loading
  - Implement the "Cache Behavior" algorithm [3]. Matching algorithms are different by content negotiation mechanism (See [2]).

[1] https://wicg.github.io/webpackage/loading.html#request-matching
[2] https://httpwg.org/http-extensions/draft-ietf-httpbis-variants.html#backports
[3] https://httpwg.org/http-extensions/draft-ietf-httpbis-variants.html#cache

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 18 (4 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/364f859e78bfc4518da481d889107ff732f69cfb

commit 364f859e78bfc4518da481d889107ff732f69cfb
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Fri Jan 18 09:07:13 2019

SignedExchange: Move StructuredHeaderParser to separate file

This will be used to parse Variants / Variant-Key header too.

Bug: 923229
Change-Id: I69e90e977a1838a942aaeb59d58c7142da8d43f4
Reviewed-on: https://chromium-review.googlesource.com/c/1415062
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624044}
[modify] https://crrev.com/364f859e78bfc4518da481d889107ff732f69cfb/content/browser/BUILD.gn
[add] https://crrev.com/364f859e78bfc4518da481d889107ff732f69cfb/content/browser/web_package/http_structured_header.cc
[add] https://crrev.com/364f859e78bfc4518da481d889107ff732f69cfb/content/browser/web_package/http_structured_header.h
[modify] https://crrev.com/364f859e78bfc4518da481d889107ff732f69cfb/content/browser/web_package/signed_exchange_signature_header_field.cc

Sign in to add a comment