Issue metadata
Sign in to add a comment
|
SitePerProcessBrowserTest.PageScaleFactorPropagatesToOOPIFs is flaky |
||||||||||||||||||
Issue descriptionFindit identified the culprit r623855 as introducing flaky test(s) summarized in https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vYjQxZmNiMDA3MTUxNmU4N2NhM2VlOGM4NGJlYThiZWIyOWRlZGM3Mww Please revert the culprit or disable the test(s) asap. If you are the owner, please fix! If the culprit above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20culprit%20r623855&comment=Link%20to%20Culprit%3A%20https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vYjQxZmNiMDA3MTUxNmU4N2NhM2VlOGM4NGJlYThiZWIyOWRlZGM3Mww Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
,
Jan 18
(4 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a32d7da36f7be01d549617b540f8622f76b88e3a commit a32d7da36f7be01d549617b540f8622f76b88e3a Author: W. James MacLean <wjmaclean@chromium.org> Date: Fri Jan 18 19:01:38 2019 Allow looser observer tolerance for final page scale factor in test. The synthetic pinch gesture mechanism used in SitePerProcessBrowserTest.PageScaleFactorPropagatesToOOPIFs is known to undershoot its target (https://crbug.com/469947), and it appears to do so in an inconsistent manner (sometimes we achieve 5% tolerance, sometimes it's more like 10%). This CL loosens the tolerance until a resolution is found for 469947. TBR=avi@chromium.org Bug: 469947, 923226 Change-Id: I2169c9e516aefa95c86ff5757309c7c24347d05c Reviewed-on: https://chromium-review.googlesource.com/c/1422419 Commit-Queue: James MacLean <wjmaclean@chromium.org> Auto-Submit: James MacLean <wjmaclean@chromium.org> Reviewed-by: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#624223} [modify] https://crrev.com/a32d7da36f7be01d549617b540f8622f76b88e3a/content/browser/site_per_process_browsertest.cc
,
Jan 18
(4 days ago)
|
|||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||
Comment 1 by wjmaclean@chromium.org
, Jan 18 (4 days ago)