Feature request: "'Merge script log'" should contain the commandline before the output |
||
Issue descriptionIn https://chromium.googlesource.com/chromium/tools/build/+/20a2968c7228cfe49e7fd1a324e20b4b9d0a73e4/scripts/slave/recipe_modules/swarming/api.py#1038 You can see that only the output of the command is in that log. So then logs look like this: https://logs.chromium.org/logs/chrome/buildbucket/cr-buildbucket.appspot.com/8924049021598982864/+/steps/performance_test_suite_on_Intel_GPU_on_Windows_on_Windows-10/0/logs/Merge_script_log/0 which makes it more difficult for a developer who is trying to understand how all the parts fit together to understand what script is doing the merging of the shard outputs. For Perf, this is a complicated step, so it would be better if it pointed people in a helpful direction.
,
Jan 18
(4 days ago)
Either that or having the merge script could dump its own argv to stdout sound fine.
,
Jan 18
(4 days ago)
never edit. Should be: "Either that or having the merge script dump its own argv to stdout sound fine."
,
Jan 18
(4 days ago)
|
||
►
Sign in to add a comment |
||
Comment 1 by crouleau@chromium.org
, Jan 18 (4 days ago)Components: Infra>Client>Chrome Speed>Benchmarks>Waterfall
I'm happy to implement this if it sounds like a good idea. All i need to do is something like: step_result.presentation.logs['Merge script log'] = task_args + ['\n', step_result.raw_io.output]