New issue
Advanced search Search tips

Issue 923206 link

Starred by 0 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature

Blocked on:
issue 923204

Blocking:
issue 677338



Sign in to add a comment

Support $i18n{} in Files app

Project Member Reported by sa...@chromium.org, Jan 18 (5 days ago)

Issue description

This tracks Files-app-specific changes to allow migrating to $i18n{}.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 21 (2 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/769fdf3e274e1d4663711cc96373ca5fb776e1ae

commit 769fdf3e274e1d4663711cc96373ca5fb776e1ae
Author: Sam McNally <sammc@chromium.org>
Date: Mon Jan 21 00:17:16 2019

Move Files app string fetching into a common location.

The files app strings will soon be used while servicing requests for
files app resources. To do so, the replacements will need to be
accessible elsewhere. Extract the population of the unchanging strings
(not affected by profile, enabled features etc.) into a common location.

Bug: 923206
Change-Id: I20897cd3903ee30bcc922c4652010b676f07df3d
Reviewed-on: https://chromium-review.googlesource.com/c/1420511
Commit-Queue: Sam McNally <sammc@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624497}
[modify] https://crrev.com/769fdf3e274e1d4663711cc96373ca5fb776e1ae/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/769fdf3e274e1d4663711cc96373ca5fb776e1ae/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[add] https://crrev.com/769fdf3e274e1d4663711cc96373ca5fb776e1ae/chrome/browser/chromeos/file_manager/file_manager_string_util.cc
[add] https://crrev.com/769fdf3e274e1d4663711cc96373ca5fb776e1ae/chrome/browser/chromeos/file_manager/file_manager_string_util.h
[modify] https://crrev.com/769fdf3e274e1d4663711cc96373ca5fb776e1ae/ui/file_manager/file_manager/test/scripts/create_test_main.py

Sign in to add a comment