New issue
Advanced search Search tips

Issue 923190 link

Starred by 1 user
Status: Fixed
Owner:
guidou@chromium.org
Closed: Jan 18
Cc:
guidou@chromium.org
niklase@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

New regression to change-source function during tab sharing

Project Member Reported by braveyao@chromium.org, Jan 18 (5 days ago) 
Chrome Version: 73.0.3672.0 
OS: all

What steps will reproduce the problem?
(1) launch latest Chromium/Canary (newer than 73.3672) with multiple tabs.
(2) start a tab sharing, with go/present or any desktopCapture samples.
(3) click "Change source" button on the notification bar and select a new tab to share

What is the expected result?
The new tab is promoted to front and shared to peer

What happens instead?
The new tab is promoted to front, but the shared tab isn't changed.

Please use labels and text to provide additional information.

If this is a regression (i.e., worked before), please consider using
the bisect tool (https://www.chromium.org/developers/bisect-builds-py)
to help us identify the root cause and more rapidly triage the issue.

Bisect result shows the range of 
https://chromium.googlesource.com/chromium/src/+log/80a72ce438f4ee31ca616f6239653ee01dac3e58..9d6ffd96fca2ea364fea8cece7516ef94750805a

And manual test shows the offending cl is https://chromium.googlesource.com/chromium/src/+/73fa66396d3c871a43f0f0e0ec28236670d7da9a

Comment 1 by braveyao@chromium.org, Jan 18 (5 days ago) 

With debug Chromium building on Linux, there is a fatal error in service_manager.cc:

[129728:129754:0117/164443.947059:FATAL:service_manager.cc(123)] Check failed: false. The Service Manager prevented service "content_browser" from binding interface "blink.mojom.MediaStreamDeviceObserver" in target service "content_renderer". You probably need to update one or more service manifests to ensure that "content_renderer" exposes "blink.mojom.MediaStreamDeviceObserver" through a capability and that "content_browser" requires that capability from the "content_renderer" service.

The detailed call stack is enclosed.
errlog.txt
8.4 KB View Download

Comment 2 by braveyao@chromium.org, Jan 18 (5 days ago)

Labels: -OS-iOS
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 18 (5 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a003db25a6e95050754a17a873d312aaa0749f04

commit a003db25a6e95050754a17a873d312aaa0749f04
Author: Guido Urdaneta <guidou@chromium.org>
Date: Fri Jan 18 05:13:17 2019

Update MediaStreamDeviceObserver in renderer manifest

This interface was moved from content to blink in
crrev.com/622534, but we forgot to update the manifest.

Bug:  923190 
Change-Id: Ib7a398ce6dfd967b361c18b39ca2b6961d1e2b20
Reviewed-on: https://chromium-review.googlesource.com/c/1419839
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624016}
[modify] https://crrev.com/a003db25a6e95050754a17a873d312aaa0749f04/content/public/app/mojo/content_renderer_manifest.json

Comment 4 by guidou@chromium.org, Jan 18 (4 days ago)

Status: Fixed (was: Assigned)
►

Sign in to add a comment