Refactor FormDataImporter::ImportFormData() |
|
Issue descriptionFunction FormDataImporter::ImportFormData() [1] returned bool value is not utilized. CL [2] refactored this area to allow for Paradise migration or Upstream upload, and it looks like ImportFormData()'s return value was redundant. We don't actually care in the rest of that function about whether an address was imported, and credit card checks are handled afterward by the ImportedCreditCardRecordType::NO_CARD and !imported_credit_card checks, so it's still not necessary. We may want to make this function inlined, currently it is kinda confusion... Especially the after importFormData call, we will reply on a field imported_credit_card_record_type_ that is set inside the function which is not passed as a param [1] https://cs.chromium.org/chromium/src/components/autofill/core/browser/form_data_importer.cc?l=218-247&rcl=f10dcbdfa1ff36b0a092e6eee4611fddc13d894d [2] https://chromium-review.googlesource.com/c/chromium/src/+/1111569/30/components/autofill/core/browser/form_data_importer.cc
,
Jan 18
(5 days ago)
|
|
►
Sign in to add a comment |
|
Comment 1 by jiahuiguo@chromium.org
, Jan 18 (5 days ago)Owner: hozhng@google.com
Status: Assigned (was: Untriaged)