New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 923179 link

Starred by 3 users
Status: Started
Owner:
pbos@chromium.org
Cc:
edwardjung@chromium.org
█ helenepark@chromium.org
markchang@chromium.org
bettes@chromium.org
pkasting@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Feature



Sign in to add a comment

Experiment with the tab icon loading animation

Project Member Reported by pbos@chromium.org, Jan 18 (5 days ago) 
After discarding the "new tab animation" we still have some things we want to try exploring with the current animation. This tracks that.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 19 (4 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7c316e2d754ec1f0ee206bb418f7e13fe31ab381

commit 7c316e2d754ec1f0ee206bb418f7e13fe31ab381
Author: Peter Boström <pbos@chromium.org>
Date: Sat Jan 19 03:26:38 2019

Experiment with displaying the favicon earlier

This starts displaying the favicon during the loading (in contrast to
connecting) part of the tab icon animation. The change is under
chrome://flags as the old new-tab-animation flag.

Bug: chromium:923179
Change-Id: Ief5a3796c5c433bc8b9b26c5ee11fbff8fb30a46
Reviewed-on: https://chromium-review.googlesource.com/c/1419009
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624435}
[modify] https://crrev.com/7c316e2d754ec1f0ee206bb418f7e13fe31ab381/chrome/browser/ui/views/tabs/tab.cc
[modify] https://crrev.com/7c316e2d754ec1f0ee206bb418f7e13fe31ab381/chrome/browser/ui/views/tabs/tab_icon.cc
[modify] https://crrev.com/7c316e2d754ec1f0ee206bb418f7e13fe31ab381/chrome/browser/ui/views/tabs/tab_icon.h
[modify] https://crrev.com/7c316e2d754ec1f0ee206bb418f7e13fe31ab381/ui/gfx/paint_throbber.cc
[modify] https://crrev.com/7c316e2d754ec1f0ee206bb418f7e13fe31ab381/ui/gfx/paint_throbber.h

Comment 2 by meh...@chromium.org, Yesterday (35 hours ago) 

Hey pbos@, after your recent landed CL, I noticed the following in latest Canary:

With the enabled new-tab-animation flag, the favicon is moving to right by 2px on my non-retina device. Probably not intended, right?

A screenshot is attached: above without and below with enabled flag.

Thanks for looking into it :)
Bildschirmfoto 2019-01-21 um 19.21.44.png
20.6 KB View Download

Comment 3 by pbos@chromium.org, Today (8 hours ago)

Cc: markchang@chromium.org edwardjung@chromium.org helenepark@chromium.org bettes@chromium.org

Comment 4 by pbos@chromium.org, Today (8 hours ago) 

Thanks mehmet@ that's certainly not expected. :)
►

Sign in to add a comment