New issue
Advanced search Search tips

Issue 923172 link

Starred by 1 user
Status: Fixed
Owner:
taku...@chromium.org
Closed: Today
Cc:
mfo...@chromium.org
taku...@chromium.org
powerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Clearing an issue is counted in the metrics as SinkNotFound

Project Member Reported by taku...@chromium.org, Jan 18 (5 days ago) 
In the Views Cast dialog, clicking on a sink to clear an issue on it is being counted in the MediaRouter.Provider.CreateRoute.Result metric as SinkNotFound. Clearing an issue should not be counted in this metric at all.
Project Member

Comment 1 by bugdroid1@chromium.org, Today (10 hours ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81d005fbbdb4620d34c0c1b25f3329544792e4bc

commit 81d005fbbdb4620d34c0c1b25f3329544792e4bc
Author: Takumi Fujimoto <takumif@chromium.org>
Date: Tue Jan 22 20:16:02 2019

[Harmony Cast Dialog] Explicitly remove issues

Clear issues shown in the Views dialog by sending explicit ClearIssue()
calls, instead of doing so by sending invalid CreateRoute() requests.

Bug:  923172 
Change-Id: I79edc224505fec1debc06d782d1fda0acd6ccaf3
Reviewed-on: https://chromium-review.googlesource.com/c/1419201
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624896}
[modify] https://crrev.com/81d005fbbdb4620d34c0c1b25f3329544792e4bc/chrome/browser/ui/media_router/cast_dialog_controller.h
[modify] https://crrev.com/81d005fbbdb4620d34c0c1b25f3329544792e4bc/chrome/browser/ui/views/media_router/cast_dialog_view.cc
[modify] https://crrev.com/81d005fbbdb4620d34c0c1b25f3329544792e4bc/chrome/browser/ui/views/media_router/cast_dialog_view_unittest.cc
[modify] https://crrev.com/81d005fbbdb4620d34c0c1b25f3329544792e4bc/chrome/browser/ui/views/media_router/media_router_views_ui.cc
[modify] https://crrev.com/81d005fbbdb4620d34c0c1b25f3329544792e4bc/chrome/browser/ui/views/media_router/media_router_views_ui.h

Comment 2 by taku...@chromium.org, Today (9 hours ago)

Status: Fixed (was: Assigned)
►

Sign in to add a comment