New issue
Advanced search Search tips

Issue 923153 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Skylab: support balancing pools preserving the SKU

Project Member Reported by pprabhu@chromium.org, Jan 17 (5 days ago)

Issue description

Currently balance_pool (in autotest and skylab) only preserves the model label when moving DUTs.

Let's support this as a first class citizen in skylab.

 

Comment 1 by pprabhu@chromium.org, Jan 17 (5 days ago)

This will require:

- add SKU label information to inventory schema (I'd skipped it because no jobs actually require a specific SKU in autotest today). See issue 913660
- update the ensure-pool-healthy API, cron job to preserve SKU information. See issue 913674
  - I do not plan on updating the `skylab ensure-pool-healthy` tool to preserve SKU information at first, since this is an edge case.


Comment 2 by pprabhu@chromium.org, Jan 17 (5 days ago)

Cc: cywang@chromium.org

Comment 3 by pprabhu@chromium.org, Jan 17 (5 days ago)

This work will require API breaking changes after https://chromium-review.googlesource.com/c/infra/infra/+/1399339 lands. But I don't intend that method to be part of the external API (only cron calls it) and no tools use it yet, so I'll do the unthinkable and update that API method to include preserving more general filters.

This is a P2 right now, since there are no pool:performance DUTs in skylab (yet).

Sign in to add a comment