Issue metadata
Sign in to add a comment
|
crosperf: fix bug that perf table not generated correctly |
||||||||||||||||||||||
Issue description
This bug was introduced by generating report for cwp mode.
When running telemetry_Crosperf to generate a report, this error occurs:
Crosperf error: TypeError('AddLabelName() takes exactly 2 arguments (1 given)',)
The AddLabelName() function takes an unnecessary argument which caused an error when perf table in the report was generated.
,
Today
(50 minutes ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/toolchain-utils/+/42199fae69016e15d6840646fac13a540aeb59ce commit 42199fae69016e15d6840646fac13a540aeb59ce Author: Zhizhou Yang <zhizhouy@google.com> Date: Wed Jan 23 05:05:21 2019 crosperf: fix bug in perf table generating This patch fixes a bug in perf table generating, by removing an unused argument from AddLabelName(). TEST=passed local unit tests and a sample test on device. BUG=chromium:923143 Change-Id: I16fb0d1baaa76be523073de1e9768c1b1ee799d6 Reviewed-on: https://chromium-review.googlesource.com/1419298 Commit-Ready: Zhizhou Yang <zhizhouy@google.com> Tested-by: Zhizhou Yang <zhizhouy@google.com> Reviewed-by: Caroline Tice <cmtice@chromium.org> [modify] https://crrev.com/42199fae69016e15d6840646fac13a540aeb59ce/cros_utils/tabulator.py
,
Today
(28 minutes ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/toolchain-utils/+/42199fae69016e15d6840646fac13a540aeb59ce commit 42199fae69016e15d6840646fac13a540aeb59ce Author: Zhizhou Yang <zhizhouy@google.com> Date: Wed Jan 23 05:05:21 2019 crosperf: fix bug in perf table generating This patch fixes a bug in perf table generating, by removing an unused argument from AddLabelName(). TEST=passed local unit tests and a sample test on device. BUG=chromium:923143 Change-Id: I16fb0d1baaa76be523073de1e9768c1b1ee799d6 Reviewed-on: https://chromium-review.googlesource.com/1419298 Commit-Ready: Zhizhou Yang <zhizhouy@google.com> Tested-by: Zhizhou Yang <zhizhouy@google.com> Reviewed-by: Caroline Tice <cmtice@chromium.org> [modify] https://crrev.com/42199fae69016e15d6840646fac13a540aeb59ce/cros_utils/tabulator.py |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by bugdroid
, Today (71 minutes ago)