New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 923140 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

base_perftests failing on chromium.perf/android-nexus5x-perf

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Jan 17 (5 days ago)

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of crouleau@google.com

base_perftests failing on chromium.perf/android-nexus5x-perf

Builders failed on: 
- android-nexus5x-perf: 
  https://ci.chromium.org/p/chrome/builders/luci.chrome.ci/android-nexus5x-perf

https://chrome-swarming.appspot.com/task?id=4274fe41fe50f510&refresh=10&show_raw=1

I 2518.645s Main  FINISHED TRY #1/1
I 2518.645s Main  4 failed tests remain.
C 2518.645s Main  ********************************************************************************
C 2518.645s Main  Detailed Logs
C 2518.645s Main  ********************************************************************************
C 2518.646s Main  [UNKNOWN] SequenceManagerPerfTest.TwoThreadPingPongTestCase/0:
C 2518.646s Main  [ RUN      ] SequenceManagerPerfTest.TwoThreadPingPongTestCase/0
C 2518.646s Main  
C 2518.646s Main  [UNKNOWN] SequenceManagerPerfTest.TwoThreadPingPongTestCase/3:
C 2518.646s Main  [ RUN      ] SequenceManagerPerfTest.TwoThreadPingPongTestCase/3
C 2518.646s Main  
C 2518.646s Main  [UNKNOWN] SequenceManagerPerfTest.TwoThreadPingPongTestCase/6:
C 2518.646s Main  [ RUN      ] SequenceManagerPerfTest.TwoThreadPingPongTestCase/6
C 2518.646s Main  
C 2518.646s Main  [UNKNOWN] SequenceManagerPerfTest.TwoThreadPingPongTestCase/9:
C 2518.646s Main  [ RUN      ] SequenceManagerPerfTest.TwoThreadPingPongTestCase/9
C 2518.646s Main  ********************************************************************************
C 2518.646s Main  Summary
C 2518.646s Main  ********************************************************************************
C 2518.646s Main  [==========] 183 tests ran.
C 2518.646s Main  [  PASSED  ] 179 tests.
C 2518.646s Main  [  FAILED  ] 4 tests, listed below:
C 2518.646s Main  [  FAILED  ] SequenceManagerPerfTest.TwoThreadPingPongTestCase/0 (UNKNOWN)
C 2518.646s Main  [  FAILED  ] SequenceManagerPerfTest.TwoThreadPingPongTestCase/3 (UNKNOWN)
C 2518.646s Main  [  FAILED  ] SequenceManagerPerfTest.TwoThreadPingPongTestCase/6 (UNKNOWN)
C 2518.646s Main  [  FAILED  ] SequenceManagerPerfTest.TwoThreadPingPongTestCase/9 (UNKNOWN)
C 2518.646s Main  


E 1195.136s run_tests_on_device(020ad055c25b1129)  gtest shard timed out.
Traceback (most recent call last):
  File "/b/swarming/w/ir/build/android/pylib/local/device/local_device_gtest_run.py", line 186, in Run
    self._component, extras=extras, raw=False, **kwargs)
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/android/decorators.py", line 57, in timeout_retry_wrapper
    retry_if_func=retry_if_func)
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/utils/timeout_retry.py", line 158, in Run
    error_log_func=error_log_func)
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/utils/reraiser_thread.py", line 198, in JoinAll
    self._JoinAll(watcher, timeout)
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/utils/reraiser_thread.py", line 170, in _JoinAll
    thread.ReraiseIfException()
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/utils/reraiser_thread.py", line 93, in run
    self._ret = self._func(*self._args, **self._kwargs)
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/utils/timeout_retry.py", line 151, in <lambda>
    child_thread = reraiser_thread.ReraiserThread(lambda: func(*args, **kwargs),
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/android/decorators.py", line 47, in impl
    return f(*args, **kwargs)
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/android/device_utils.py", line 1342, in StartInstrumentation
    large_output=True)
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/android/decorators.py", line 51, in timeout_retry_wrapper
    return impl()
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/android/decorators.py", line 47, in impl
    return f(*args, **kwargs)
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/android/device_utils.py", line 1161, in RunShellCommand
    output = handle_large_output(cmd, large_output)
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/android/device_utils.py", line 1126, in handle_large_output
    handle_large_command(cmd)
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/android/device_utils.py", line 1118, in handle_large_command
    return handle_check_return('sh %s' % script.name_quoted)
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/android/device_utils.py", line 1103, in handle_check_return
    return run(cmd)
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/android/device_utils.py", line 1099, in run
    return self.adb.Shell(cmd)
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/android/sdk/adb_wrapper.py", line 533, in Shell
    output = self._RunDeviceAdbCmd(args, timeout, retries, check_error=False)
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/android/sdk/adb_wrapper.py", line 316, in _RunDeviceAdbCmd
    check_error=check_error)
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/android/decorators.py", line 51, in timeout_retry_wrapper
    return impl()
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/android/decorators.py", line 47, in impl
    return f(*args, **kwargs)
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/android/sdk/adb_wrapper.py", line 277, in _RunAdbCmd
    timeout, env=cls._ADB_ENV)
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/utils/cmd_helper.py", line 425, in GetCmdStatusAndOutputWithTimeout
    raise TimeoutError(output.getvalue())

 

Comment 1 by crouleau@chromium.org, Jan 18 (5 days ago)

Cc: gab@chromium.org skyos...@chromium.org
Components: Internals>SequenceManager

Comment 2 by crouleau@chromium.org, Jan 18 (5 days ago)

Starting functional bisect from 623593 to 623666
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Jan 18 (5 days ago)

Comment 5 by skyos...@chromium.org, Jan 18 (4 days ago)

Owner: alexclarke@chromium.org
Status: Assigned (was: Available)
Looks like the new test we added is failing.

Comment 6 by crouleau@chromium.org, Jan 18 (4 days ago)

Could we just revert the change that added the new test please? We would like to keep this bot green.
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 19 (4 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a193551625c7b7e535f4ab24fd11a7e0b1a825c

commit 5a193551625c7b7e535f4ab24fd11a7e0b1a825c
Author: Caleb Rouleau <crouleau@chromium.org>
Date: Sat Jan 19 00:27:45 2019

Revert "Add a perf test that PingPongs tasks between two threads."

This reverts commit f95cea1ee97833d805af100c43bbb0317333513c.

Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=923140

BUG=923140

Original change's description:
> Add a perf test that PingPongs tasks between two threads.
> 
> Change-Id: I8b0a3907d9009d50e9b624e1eb299f90bc87a14d
> Reviewed-on: https://chromium-review.googlesource.com/c/1414898
> Commit-Queue: Alex Clarke <alexclarke@chromium.org>
> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
> Reviewed-by: Alexander Timin <altimin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#623643}

TBR=skyostil@chromium.org,alexclarke@chromium.org,altimin@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I5b40c52ce380cd2f882394923da764d74d0936e7
Reviewed-on: https://chromium-review.googlesource.com/c/1423355
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624377}
[modify] https://crrev.com/5a193551625c7b7e535f4ab24fd11a7e0b1a825c/base/task/sequence_manager/sequence_manager_perftest.cc

Project Member

Comment 9 by 42576172...@developer.gserviceaccount.com, Jan 19 (3 days ago)

Cc: alexclarke@chromium.org
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/15790a8a540000

Add a perf test that PingPongs tasks between two threads. by alexclarke@chromium.org
https://chromium.googlesource.com/chromium/src/+/f95cea1ee97833d805af100c43bbb0317333513c
Failure rate: 0 → 1 (+1)

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Sign in to add a comment