New issue
Advanced search Search tips

Issue 923115 link

Starred by 1 user
Status: Fixed
Owner:
spang@chromium.org
Closed: Yesterday
Cc:
sergeyu@chromium.org
rjkroege@chromium.org
kpschoedel@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 1
Type: Bug



Sign in to add a comment

bring up gpu_unittests on Fuchsia

Project Member Reported by spang@chromium.org, Jan 17 (5 days ago) 
Even without vangle brought up at lot of these some of these look like they can be fixed already (e.g. message loops deps that are not satisfied by test runner)

1 test failed:
    GPUTestConfigTest.LoadCurrentConfig (../../gpu/config/gpu_test_config_unittest.cc:267)
18 tests crashed:
    GPUConfig/GPUInfoCollectorTest.CollectGraphicsInfoGL/0 (../../gpu/config/gpu_info_collector_unittest.cc:201)
    GPUConfig/GPUInfoCollectorTest.CollectGraphicsInfoGL/1 (../../gpu/config/gpu_info_collector_unittest.cc:201)
    GPUConfig/GPUInfoCollectorTest.CollectGraphicsInfoGL/2 (../../gpu/config/gpu_info_collector_unittest.cc:201)
    GPUConfig/GPUInfoCollectorTest.CollectGraphicsInfoGL/3 (../../gpu/config/gpu_info_collector_unittest.cc:201)
    GpuChannelExitForContextLostTest.CreateFailsDuringLostContextShutdown (../../gpu/ipc/service/gpu_channel_unittest.cc:240)
    GpuChannelManagerTest.EstablishChannel (../../gpu/ipc/service/gpu_channel_manager_unittest.cc:73)
    GpuChannelTest.CreateFailsIfSharedContextIsLost (../../gpu/ipc/service/gpu_channel_unittest.cc:150)
    GpuChannelTest.CreateOffscreenCommandBuffer (../../gpu/ipc/service/gpu_channel_unittest.cc:81)
    GpuChannelTest.CreateViewCommandBufferAllowed (../../gpu/ipc/service/gpu_channel_unittest.cc:23)
    GpuChannelTest.CreateViewCommandBufferDisallowed (../../gpu/ipc/service/gpu_channel_unittest.cc:52)
    GpuChannelTest.IncompatibleStreamIds (../../gpu/ipc/service/gpu_channel_unittest.cc:106)
    ImageDecodeAcceleratorStubTest.FailedDecodes (../../gpu/ipc/service/image_decode_accelerator_stub_unittest.cc:242)
    ImageDecodeAcceleratorStubTest.MultipleDecodesCompletedAfterSequenceIsDisabled (../../gpu/ipc/service/image_decode_accelerator_stub_unittest.cc:161)
    ImageDecodeAcceleratorStubTest.MultipleDecodesCompletedWhileSequenceIsEnabled (../../gpu/ipc/service/image_decode_accelerator_stub_unittest.cc:202)
    ImageDecodeAcceleratorStubTest.OutOfOrderSyncTokens (../../gpu/ipc/service/image_decode_accelerator_stub_unittest.cc:277)
    ImageDecodeAcceleratorStubTest.ZeroHeightOutputSize (../../gpu/ipc/service/image_decode_accelerator_stub_unittest.cc:315)
    ImageDecodeAcceleratorStubTest.ZeroReleaseCountSyncToken (../../gpu/ipc/service/image_decode_accelerator_stub_unittest.cc:293)
    ImageDecodeAcceleratorStubTest.ZeroWidthOutputSize (../../gpu/ipc/service/image_decode_accelerator_stub_unittest.cc:304)
Tests took 11 seconds.

Comment 1 by spang@chromium.org, Jan 17 (5 days ago)

Owner: spang@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 18 (4 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b29875a0f1ac9c515df5b02195ad7997d0b3e7b

commit 9b29875a0f1ac9c515df5b02195ad7997d0b3e7b
Author: Michael Spang <spang@chromium.org>
Date: Fri Jan 18 23:25:39 2019

Bring up gpu_unittests on Fuchsia

Add Fuchsia to the list of possible operating systems in GPUTestConfig.

Disable GpuFenceManagerTest since it depends on
EGL_ANDROID_native_fence_sync, which is not something that Fuchsia will
have.

Work around the fact that many tests initialize the GPU without providing
a message loop.

Bug:  923115 
Test: out/fuchsia_rel/bin/run_gpu_unittests

Change-Id: I9d55118a99ad1f8fd0f62296b4af668d0c75290f

Reviewed-on: https://chromium-review.googlesource.com/c/1419282
Commit-Queue: Michael Spang <spang@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624349}
[modify] https://crrev.com/9b29875a0f1ac9c515df5b02195ad7997d0b3e7b/gpu/BUILD.gn
[modify] https://crrev.com/9b29875a0f1ac9c515df5b02195ad7997d0b3e7b/gpu/config/gpu_test_config.cc
[modify] https://crrev.com/9b29875a0f1ac9c515df5b02195ad7997d0b3e7b/gpu/config/gpu_test_config.h
[modify] https://crrev.com/9b29875a0f1ac9c515df5b02195ad7997d0b3e7b/ui/ozone/platform/scenic/ozone_platform_scenic.cc
[modify] https://crrev.com/9b29875a0f1ac9c515df5b02195ad7997d0b3e7b/ui/ozone/platform/scenic/scenic_surface_factory.cc

Comment 3 by spang@chromium.org, Yesterday (35 hours ago)

Status: Fixed (was: Started)
Project Member

Comment 4 by bugdroid, Today (9 hours ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d5af07da0d65b99d62107f13ff0141285ce7765a

commit d5af07da0d65b99d62107f13ff0141285ce7765a
Author: Michael Spang <spang@chromium.org>
Date: Tue Jan 22 21:13:21 2019

testing: Enable gpu_unittests on Fuchsia

Bug:  923115 
Test: gpu_unittests
Change-Id: Iba377a6cb229a9170195439f9ff806db8fd8f3e3
Reviewed-on: https://chromium-review.googlesource.com/c/1426004
Reviewed-by: Marc-Antoine Ruel <maruel@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624920}
[modify] https://crrev.com/d5af07da0d65b99d62107f13ff0141285ce7765a/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/d5af07da0d65b99d62107f13ff0141285ce7765a/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/d5af07da0d65b99d62107f13ff0141285ce7765a/testing/buildbot/test_suites.pyl
►

Sign in to add a comment