New issue
Advanced search Search tips

Issue 923109 link

Starred by 1 user
Status: Verified
Owner:
mrsuyi@chromium.org
Closed: Jan 18
Cc:
justincohen@chromium.org
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug-Regression



Sign in to add a comment

NTP animation broken when opening tabs from tab switcher

Project Member Reported by srikanthg@chromium.org, Jan 17 (5 days ago) 
App Version: 73.0.3674.0 canary
iOS Version: 12.1.3, 12.1.2
Device: iPhoneX, iPhone7Plus
URL: NA

Steps to reproduce:
  1. Launch Google Chrome
  2. Enter Tab Switcher
  3. Open a new tab using the Plus sign

Observed results: Observe that the animation is broken, grey bar is displayed at the bottom during the animation.

Expected results: Animation should be smooth.

Good Version 73.0.3673.0 #0cc739b
 Bad Version 73.0.3674.0 #8a30e45

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: NA
Bug reproducible on Safari/Firefox: Firefox:NA , Safari: NA
Bug reproducible on current stable build (App Version, iOS Version): M71 NO
Bug reproducible on the current beta channel build (App Version, iOS Version): M72 NO

Link to video/image: https://drive.google.com/file/d/1cAXWrNtw_daUox-vgMH97zAUKoOP7PiE/view

Comment 1 by justincohen@chromium.org, Jan 17 (5 days ago)

Cc: justincohen@chromium.org
Labels: M-73
Owner: mrsuyi@chromium.org
Thanks for the bisect.  Appears to be 845594fab3d16176e416a25a65b9b9d5490effef, https://chromium-review.googlesource.com/c/chromium/src/+/1409546
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 18 (5 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7eaa39c9fd92d0130726f09ef1c116c8bf713500

commit 7eaa39c9fd92d0130726f09ef1c116c8bf713500
Author: Justin Cohen <justincohen@chromium.org>
Date: Fri Jan 18 00:09:06 2019

Revert "Use bigger tab view under accessibility font size."

This reverts commit 845594fab3d16176e416a25a65b9b9d5490effef.

Reason for revert: Breaks NTP animation

Bug:  923109 , 893540

Original change's description:
> Use bigger tab view under accessibility font size.
> 
> This CL adjusts the size of tab views and height of their titles in tab
> grid under accessibility font size. Title will be displayed in 2 lines
> when accessibility font size is chosen.
> 
> Screen shots:
> iPhoneXR:   https://drive.google.com/open?id=1anVBsA3cOBumUqt38OpM6FtprLBFfup5
> 
> iPad landscape:
> 50%:  https://drive.google.com/open?id=1E9m9Viqhval_l9Est8U1-sQktI7c_38l
> 66%:  https://drive.google.com/open?id=1GuXD-miJgBPL3FnhlSRLoDrKMFa9xv0w
> 100%: https://drive.google.com/open?id=1jiAutUdf-wcACcckxtFbJFmS_S-2f7t2
> 
> iPad Portrait:
> 40%:  https://drive.google.com/open?id=1A9WsE-_vT0kdzuAhEDNQH-UQtVqLGF53
> 60%:  https://drive.google.com/open?id=1CR-holR-9JcuvMBjadrzWjcoDFuaJU4i
> 100%: https://drive.google.com/open?id=1k8BCFtqKavozdpoihA7tYg3PT7ho7Eo7
> 
> Bug: 893540
> Change-Id: I314d081439909cf6f3711d06df579c73a9685e99
> Reviewed-on: https://chromium-review.googlesource.com/c/1409546
> Reviewed-by: edchin <edchin@chromium.org>
> Commit-Queue: Yi Su <mrsuyi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#623172}

TBR=edchin@chromium.org,mrsuyi@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 893540
Change-Id: I9255619f7a49adb4fc7b2326a5cb288d3be26725
Reviewed-on: https://chromium-review.googlesource.com/c/1419258
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623923}
[modify] https://crrev.com/7eaa39c9fd92d0130726f09ef1c116c8bf713500/ios/chrome/browser/ui/tab_grid/grid/grid_cell.mm
[modify] https://crrev.com/7eaa39c9fd92d0130726f09ef1c116c8bf713500/ios/chrome/browser/ui/tab_grid/grid/grid_constants.h
[modify] https://crrev.com/7eaa39c9fd92d0130726f09ef1c116c8bf713500/ios/chrome/browser/ui/tab_grid/grid/grid_constants.mm
[modify] https://crrev.com/7eaa39c9fd92d0130726f09ef1c116c8bf713500/ios/chrome/browser/ui/tab_grid/grid/grid_layout.mm
[modify] https://crrev.com/7eaa39c9fd92d0130726f09ef1c116c8bf713500/ios/chrome/browser/ui/tab_grid/grid/grid_view_controller.mm

Comment 3 by justincohen@chromium.org, Jan 18 (5 days ago)

Status: Fixed (was: Untriaged)

Comment 4 by rakurati@chromium.org, Today (21 hours ago)

Status: Verified (was: Fixed)
Verified in 
Build: 73.0.3680.0 Canary
Device Details:iPhone 8plus(iOS 12.1.3 beta #4), iPhone 8(iOS 11.4.1)

Followed the steps mentioned in comment#0. grey bar is not displayed at the bottom the animation is now smooth, looks good.

Link to video:
https://drive.google.com/file/d/1NaidPXdeh55FB9PVtW0qPUgtQGBXg6Lj/view?usp=sharing
►

Sign in to add a comment