OS: Windows
When debugging a renderer process the browser process may "helpfully" point out that the renderer has hung. Well, yes. I know that. I'm sitting at a breakpoint. This is not helpful. Avoiding the hung renderer messages in this case would smooth out this workflow.
There is already code to do this in some cases:
bool WebContentsImpl::ShouldIgnoreUnresponsiveRenderer() {
// Ignore unresponsive renderers if the debugger is attached to them since the
// unresponsiveness might be a result of the renderer sitting on a breakpoint.
//
// TODO(pfeldman): Fix this to only return true if the renderer is *actually*
// sitting on a breakpoint. https://crbug.com/684202
return DevToolsAgentHost::IsDebuggerAttached(this);
}
https://cs.chromium.org/chromium/src/content/browser/web_contents/web_contents_impl.cc?type=cs&q=ShouldIgnoreUnresponsiveRenderer&sq=package:chromium&g=0&l=3098
but this code is apparently not working or hooked up on Windows.
The CheckRemoteDebuggerPresent function can be used to query the IsDebuggerPresent status of another process. This function is currently not called anywhere in Chromium which is probably why DevToolsAgentHost::IsDebuggerAttached() is not having the desired affect on Windows.
See also crbug.com/888120 and the associated CL link. CCing a few relevant people.
Comment 1 by davidbienvenu@chromium.org
, Jan 17 (5 days ago)Status: Assigned (was: Available)