New issue
Advanced search Search tips

Issue 923078 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 794619



Sign in to add a comment

Use url_formatter in media session

Project Member Reported by beccahughes@chromium.org, Jan 17 (5 days ago)

Issue description

We should use url_formatter for the source title in content::MediaSessionImpl. However, url_formatter pulls in some of //ui which has shadowed enums and content has shadowing disabled.
 

Comment 1 by brat...@opera.com, Jan 18 (4 days ago)

I tried enabling noshadowing in components/url_formatter but it triggered no warnings in my local configuration. Do you recall where the errors were?

Comment 2 by brat...@opera.com, Jan 18 (4 days ago)

I ran an older version of clang which didn't have warnings for shadowed enums. https://chromium-review.googlesource.com/c/chromium/src/+/1421104 has a potential fix. A bit bigger than I would have liked.

Comment 3 by beccahughes@chromium.org, Jan 18 (4 days ago)

I see you found it :) Thank you for fixing it!

Sign in to add a comment