New issue
Advanced search Search tips

Issue 923068 link

Starred by 1 user
Status: Started
Owner:
akihiroota@google.com
Cc:
dtseng@chromium.org
dmazz...@chromium.org
lpalmaro@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature
Team-Accessibility



Sign in to add a comment

Add ChromeVox feature to automatically switch output language

Project Member Reported by akihiroota@google.com, Jan 17 (5 days ago) 
Feature description:

Add a ChromeVox feature to dynamically switch output language. For example, if the ChromeVox voice is set to "Chrome OS US English" and it encounters text in French, ChromeVox will automatically verbalize that text in the "Chrome OS Francais" voice. 

Eng owner: akihiroota@
Product owner: lpalmaro@

Below is a link to the design document: 

https://docs.google.com/document/d/1Kq3VcTrtOstBDfJz1zuZuRW2cDg02RPVxyIfTS0G84s/edit?usp=sharing

Comment 1 by akihiroota@google.com, Jan 17 (5 days ago)

Description: Show this description
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 18 (4 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ff6f8afb698ea8c9fe6653b91d9bee0acf31d67

commit 3ff6f8afb698ea8c9fe6653b91d9bee0acf31d67
Author: Akihiro Ota <akihiroota@chromium.org>
Date: Fri Jan 18 17:43:04 2019

Add feature flag for ChromeVox language switching feature.

This change only creates the flag, it does not implement any
functionality.

Change-Id: I501dc8b27c3906c61c7549e89c33cb15360e15c1
Bug: 923068
Reviewed-on: https://chromium-review.googlesource.com/c/1415255
Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624187}
[modify] https://crrev.com/3ff6f8afb698ea8c9fe6653b91d9bee0acf31d67/chrome/browser/about_flags.cc
[modify] https://crrev.com/3ff6f8afb698ea8c9fe6653b91d9bee0acf31d67/chrome/browser/flag-metadata.json
[modify] https://crrev.com/3ff6f8afb698ea8c9fe6653b91d9bee0acf31d67/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/3ff6f8afb698ea8c9fe6653b91d9bee0acf31d67/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/3ff6f8afb698ea8c9fe6653b91d9bee0acf31d67/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/3ff6f8afb698ea8c9fe6653b91d9bee0acf31d67/ui/accessibility/accessibility_switches.cc
[modify] https://crrev.com/3ff6f8afb698ea8c9fe6653b91d9bee0acf31d67/ui/accessibility/accessibility_switches.h
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 18 (4 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff0729dcd0e2016e55ae26494ed97553b616f3d8

commit ff0729dcd0e2016e55ae26494ed97553b616f3d8
Author: Akihiro Ota <akihiroota@chromium.org>
Date: Fri Jan 18 18:05:32 2019

Add checkbox for language switching to ChromeVox options page.

This change simply creates the checkbox to toggle this feature.
It doesn't implement any logic, it simply creates the UI element
and ensures that it's accessible.

Change-Id: I0d9e3ade92c06db38acdd0b99e3d033cff4ec0ba
Bug: 923068
Reviewed-on: https://chromium-review.googlesource.com/c/1416810
Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624200}
[modify] https://crrev.com/ff0729dcd0e2016e55ae26494ed97553b616f3d8/chrome/browser/resources/chromeos/chromevox/chromevox/background/options.html
[modify] https://crrev.com/ff0729dcd0e2016e55ae26494ed97553b616f3d8/chrome/browser/resources/chromeos/chromevox/chromevox/background/options.js
[modify] https://crrev.com/ff0729dcd0e2016e55ae26494ed97553b616f3d8/chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings.grd
►

Sign in to add a comment