New issue
Advanced search Search tips

Issue 923058 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Fuchsia
Pri: 1
Type: Bug

Blocking:
issue 922663



Sign in to add a comment

[Fuchsia] Remove "inspector" resources (and code, if any is present) from WebEngine package

Project Member Reported by w...@chromium.org, Jan 17 (5 days ago)

Issue description

Our WebEngine package includes a resources/ directory that has only an inspector/ subdirectory, containing ~10MB of resources (JS, HTML, etc) for the Developer Tools inspector UI. Since we don't actuall provide DevTools in the WebEngine (and would likely distribute it as a separate, optional package, if we did!) we should remove those files.
 

Comment 1 by w...@chromium.org, Jan 17 (5 days ago)

Blocking: 922663

Comment 2 by w...@chromium.org, Jan 17 (5 days ago)

See also US-582.

Comment 3 by w...@chromium.org, Jan 18 (4 days ago)

Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 19 (4 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ed5423958e3b3e398bcbd7bbfa9f36888b10b502

commit ed5423958e3b3e398bcbd7bbfa9f36888b10b502
Author: Kevin Marshall <kmarshall@chromium.org>
Date: Sat Jan 19 00:01:38 2019

[fuchsia] Exclude DevTools front-end and WebUI resources from build.

The Fuchsia port of Chromium does not support the DevTools front-end.
We can reduce the overall size of the package by excluding the unused
resources, easing storage pressures on constrained devices.
The same logic applies to WebUI.


Bug: 923058
Change-Id: Ie3e91fd6fc968f2921864889c9aab1d12315b525
Reviewed-on: https://chromium-review.googlesource.com/c/1418501
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624367}
[modify] https://crrev.com/ed5423958e3b3e398bcbd7bbfa9f36888b10b502/content/browser/BUILD.gn
[modify] https://crrev.com/ed5423958e3b3e398bcbd7bbfa9f36888b10b502/content/browser/devtools/devtools_frontend_host_impl.cc
[modify] https://crrev.com/ed5423958e3b3e398bcbd7bbfa9f36888b10b502/content/browser/devtools/devtools_http_handler.cc
[modify] https://crrev.com/ed5423958e3b3e398bcbd7bbfa9f36888b10b502/fuchsia/BUILD.gn

Sign in to add a comment