MimeHandlerViewTest.Iframe and SmartSessionRestoreTest.CorrectLoadingOrder are failing in single_process_mash_browser_tests on linux-chromeos-dbg |
||
Issue descriptionMost recent failures: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-dbg/10320 They both have been failing for a few builds since yesterday. SmartSessionRestoreTest.CorrectLoadingOrder appears to be flaky, while MimeHandlerViewTest.Iframe seems to be reliably failing. FindIt couldn't find a culprit CL. James, we already have an entry to exclude SmartSessionRestoreTest.* in chromeos.mash.fyi.browser_tests.filter https://cs.chromium.org/chromium/src/testing/buildbot/filters/chromeos.mash.fyi.browser_tests.filter?type=cs&q=SmartSessionRestoreTest&sq=package:chromium&g=0&l=114 Not sure if that builder honors that file.
,
Jan 17
(5 days ago)
James, should we disable these tests? Is there a corresponding filter for single process mash?
,
Jan 17
(5 days ago)
,
Jan 17
(5 days ago)
MimeHandlerViewTest.Iframe fails on ASAN too. We no longer use a filter file for single process mash since we plan to turn it on by default. For now, we have to disable it in code and make sure to have a tracking bug. e.g. // TODO(https://crbug.com/923051): Flaky in single process mash. if (features::IsSingleProcessMash()) return;
,
Jan 17
(5 days ago)
Thanks, xiyuan! [single_process_mash_browser_tests] SmartSessionRestoreTest.CorrectLoadingOrder is also flaky now.
,
Jan 17
(5 days ago)
Opps that's the same test from before. Sorry.
,
Jan 17
(5 days ago)
,
Jan 18
(5 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/08c4a083745a871a25e6095d4a423ae36a9d9973 commit 08c4a083745a871a25e6095d4a423ae36a9d9973 Author: Ahmed Fakhry <afakhry@chromium.org> Date: Fri Jan 18 04:11:00 2019 Disable flaky tests in SingleProcessMash TBR=sky@chromium.org, fsamuel@chromium.org BUG=923051 Change-Id: Ia1756667308a47105621dcb4015987db09f23c97 Reviewed-on: https://chromium-review.googlesource.com/c/1418521 Reviewed-by: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by: James Cook <jamescook@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#624004} [modify] https://crrev.com/08c4a083745a871a25e6095d4a423ae36a9d9973/chrome/browser/sessions/session_restore_browsertest.cc [modify] https://crrev.com/08c4a083745a871a25e6095d4a423ae36a9d9973/extensions/browser/guest_view/mime_handler_view/mime_handler_view_browsertest.cc |
||
►
Sign in to add a comment |
||
Comment 1 by jamescook@chromium.org
, Jan 17 (5 days ago)