Issue metadata
Sign in to add a comment
|
2.2%-7.8% regression in system_health.memory_desktop at 621059:621951 |
||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Jan 17
(5 days ago)
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/17d104d8540000
,
Yesterday
(46 hours ago)
📍 Found significant differences after each of 2 commits. https://pinpoint-dot-chromeperf.appspot.com/job/17d104d8540000 Fix audio service quit timeout logic. by maxmorin@chromium.org https://chromium.googlesource.com/chromium/src/+/f10ae53e17c31f66b1597f535e4ceeacb820ced0 memory:chrome:all_processes:reported_by_chrome:malloc:effective_size: 1.238e+07 → 1.281e+07 (+4.302e+05) Add GWP-ASan to field trial testing config. by vtsyrklevich@chromium.org https://chromium.googlesource.com/chromium/src/+/38a132967c0ebc3fa2a512a940c9789b5888efec memory:chrome:all_processes:reported_by_chrome:malloc:effective_size: 1.261e+07 → 1.302e+07 (+4.052e+05) Understanding performance regressions: http://g.co/ChromePerformanceRegressions Benchmark documentation link: https://bit.ly/system-health-benchmarks
,
Today
(6 hours ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d67de4bf7864713373d14216d34e86e4f9695b28 commit d67de4bf7864713373d14216d34e86e4f9695b28 Author: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Date: Tue Jan 22 23:25:14 2019 GWP-ASan: Allocate SlotMetadata array dynamically Dynamically allocating SlotMetadata reduces the amount of memory consumed in the current default configuration by ~6 kilobytes, or about 13% of the GWP-ASan memory overhead. Furthermore, it sets up the following change that eliminates the use of base::debug::StackTrace and places the addresses directly in the SlotMetadata. Bug: 896019, 921237, 923050 Change-Id: Ib60533821011a7aaeccc8278bc0ed7d747474a06 Reviewed-on: https://chromium-review.googlesource.com/c/1427440 Reviewed-by: Vitaly Buka <vitalybuka@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Auto-Submit: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#624983} [modify] https://crrev.com/d67de4bf7864713373d14216d34e86e4f9695b28/components/gwp_asan/client/guarded_page_allocator.cc [modify] https://crrev.com/d67de4bf7864713373d14216d34e86e4f9695b28/components/gwp_asan/client/guarded_page_allocator.h [modify] https://crrev.com/d67de4bf7864713373d14216d34e86e4f9695b28/components/gwp_asan/common/allocator_state.cc [modify] https://crrev.com/d67de4bf7864713373d14216d34e86e4f9695b28/components/gwp_asan/common/allocator_state.h [modify] https://crrev.com/d67de4bf7864713373d14216d34e86e4f9695b28/components/gwp_asan/common/allocator_state_unittest.cc [modify] https://crrev.com/d67de4bf7864713373d14216d34e86e4f9695b28/components/gwp_asan/crash_handler/crash_analyzer.cc [modify] https://crrev.com/d67de4bf7864713373d14216d34e86e4f9695b28/components/gwp_asan/crash_handler/crash_analyzer.h [modify] https://crrev.com/d67de4bf7864713373d14216d34e86e4f9695b28/tools/metrics/histograms/enums.xml |
|||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Jan 17 (5 days ago)