See the link to graphs below.
All graphs for this bug: https://chromeperf.appspot.com/group_report?bug_id=923044 (For debugging:) Original alerts at time of bug-filing: https://chromeperf.appspot.com/group_report?sid=2daaea56977242f1cd0cf75d4a3930e76042f9b5bd3307f782e430ae1faebf73 Bot(s) for this bug's original alert(s): mac-10_13_laptop_high_end-perf system_health.memory_desktop - Benchmark documentation link: https://bit.ly/system-health-benchmarks
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/16b7e32c540000
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/16b7e32c540000 Touch action hit test display items should count as drawable content by pdr@chromium.org https://chromium.googlesource.com/chromium/src/+/1289c6b4d058c790f2d69a2f307e603e18e5cca0 memory:chrome:all_processes:reported_by_chrome:cc:effective_size: 5.464e+07 → 6.098e+07 (+6.349e+06) Understanding performance regressions: http://g.co/ChromePerformanceRegressions Benchmark documentation link: https://bit.ly/system-health-benchmarks
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4c576a96764955856d362bdb2f8a32e11a80a978 commit 4c576a96764955856d362bdb2f8a32e11a80a978 Author: Philip Rogers <pdr@chromium.org> Date: Tue Jan 22 21:38:16 2019 Do not mark cc::Layers as drawing content for touch-action rects https://crrev.com/622468 started marking GraphicsLayers as having drawn content if they would paint touch-action rects, for the purposes of ensuring touch-action rects would be painted by blink. This marked more cc::Layers as having DrawsContent which caused a memory regression. This patch adds GraphicsLayer::PaintsHitTest which tracks whether blink needs to paint hit tests but does not mark the cc::Layer as having drawn content. This is possible because blink's hit test display items are internal to blink and are dropped at the blink->cc boundary (HitTestDisplayItems are only used by blink to ensure paint chunks are updated with hit test data). This fixes the performance regression. Bug: 923044 Change-Id: I291605d31e6cb719b1813c35ccaa026e9b8a208f Reviewed-on: https://chromium-review.googlesource.com/c/1426000 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Xianda Sun <sunxd@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#624931} [modify] https://crrev.com/4c576a96764955856d362bdb2f8a32e11a80a978/third_party/blink/renderer/core/frame/local_frame_view.cc [modify] https://crrev.com/4c576a96764955856d362bdb2f8a32e11a80a978/third_party/blink/renderer/core/page/scrolling/scrolling_coordinator.cc [modify] https://crrev.com/4c576a96764955856d362bdb2f8a32e11a80a978/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.cc [modify] https://crrev.com/4c576a96764955856d362bdb2f8a32e11a80a978/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping.h [modify] https://crrev.com/4c576a96764955856d362bdb2f8a32e11a80a978/third_party/blink/renderer/core/paint/compositing/composited_layer_mapping_test.cc [modify] https://crrev.com/4c576a96764955856d362bdb2f8a32e11a80a978/third_party/blink/renderer/core/paint/paint_layer.cc [modify] https://crrev.com/4c576a96764955856d362bdb2f8a32e11a80a978/third_party/blink/renderer/core/paint/paint_layer_scrollable_area.cc [modify] https://crrev.com/4c576a96764955856d362bdb2f8a32e11a80a978/third_party/blink/renderer/platform/graphics/graphics_layer.cc [modify] https://crrev.com/4c576a96764955856d362bdb2f8a32e11a80a978/third_party/blink/renderer/platform/graphics/graphics_layer.h [modify] https://crrev.com/4c576a96764955856d362bdb2f8a32e11a80a978/third_party/blink/web_tests/fullscreen/compositor-touch-hit-rects-fullscreen-video-controls-expected.txt [modify] https://crrev.com/4c576a96764955856d362bdb2f8a32e11a80a978/third_party/blink/web_tests/platform/linux/virtual/android/fullscreen/compositor-touch-hit-rects-fullscreen-video-controls-expected.txt [delete] https://crrev.com/c1c16d154e5d9b5acf3d469cdfb1b574c93fc638/third_party/blink/web_tests/virtual/android/fullscreen/compositor-touch-hit-rects-fullscreen-video-controls-expected.txt
Comment 1 by 42576172...@developer.gserviceaccount.com
, Jan 17 (5 days ago)