New issue
Advanced search Search tips

Issue 923043 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Yesterday
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

13.3% regression in blink_perf.css at 622449:622693

Project Member Reported by tdres...@chromium.org, Jan 17 (5 days ago)

Issue description

See the link to graphs below.
 
Project Member

Comment 1 by 42576172...@developer.gserviceaccount.com, Jan 17 (5 days ago)

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=923043

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=543f0aafebb38c908552c8d9b65d39ee8a0ce1e887dca416e7d04ac3eca96bcc


Bot(s) for this bug's original alert(s):

android-nexus5x-perf

blink_perf.css - Benchmark documentation link:
  https://bit.ly/blink-perf-benchmarks
Project Member

Comment 2 by 42576172...@developer.gserviceaccount.com, Jan 17 (5 days ago)

Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Jan 19 (3 days ago)

Cc: chromium...@skia-corp.google.com.iam.gserviceaccount.com dullweber@chromium.org f...@opera.com manukh@chromium.org wangxianzhu@chromium.org xidac...@chromium.org neis@chromium.org eyaich@google.com tom....@microsoft.com
Owner: wangxianzhu@chromium.org
Status: Assigned (was: Unconfirmed)
📍 Found significant differences after each of 9 commits.
https://pinpoint-dot-chromeperf.appspot.com/job/16de9f58540000

Migrate browsing_data helpers to OnceCallback by dullweber@chromium.org
https://chromium.googlesource.com/chromium/src/+/96254d48e5941c8808124f16781d4745fe575958
CSSPropertyUpdateValue: 9538 → 9758 (+219.6)

Use .rdata as section name for asm targeting COFF by Tom.Tan@microsoft.com
https://chromium.googlesource.com/v8/v8/+/485136287e377f1b6bd8205d215f872b1db20629
CSSPropertyUpdateValue: 9729 → 9603 (-126)

Reland^3 "[turbofan] Use feedback when reducing global loads/stores." by neis@chromium.org
https://chromium.googlesource.com/v8/v8/+/8683116e64335a99ecc403c509587410db070cd1
CSSPropertyUpdateValue: 9654 → 8404 (-1250)

[omnibox chrome:omnibox] Connect the browser's omnibox, CL 1 of 2 by manukh@chromium.org
https://chromium.googlesource.com/chromium/src/+/fc6de262fa45f445a3d62ce94d609cdd0d62b459
CSSPropertyUpdateValue: 8230 → 8394 (+164.7)

Roll src/clank b96c64dcd91c..db2ecc5544f7 (1 commits) by chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com
https://chrome-internal.googlesource.com/chrome/src-internal/+/0fa708cf8229324e120bde962826c3e526d9c4d5
CSSPropertyUpdateValue: 8373 → 8521 (+148)

[Debugging] Add DumpWithoutCrash in more cases by xidachen@chromium.org
https://chromium.googlesource.com/chromium/src/+/edabab55d7f4c7705e708723c39780458a5adc4d
CSSPropertyUpdateValue: 8603 → 8402 (-200.4)

Adding navigationId to the user timing events. by eyaich@google.com
https://chromium.googlesource.com/chromium/src/+/161ea1266c42693334a27e47a6291936c67f01ce
CSSPropertyUpdateValue: 8424 → 8821 (+397.2)

Reduce the size of execution_context.h by fs@opera.com
https://chromium.googlesource.com/chromium/src/+/2b32f46e421683240c8cede7069940cc909c2145
CSSPropertyUpdateValue: 8821 → 8247 (-573.9)

Reland "Reland "[PE] Fix background-image on ::first-line"" by wangxianzhu@chromium.org
https://chromium.googlesource.com/chromium/src/+/bd339720737e44c9d730bb8a71990f30f6dd4ccf
CSSPropertyUpdateValue: 8251 → 8600 (+349.1)

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Benchmark documentation link:
  https://bit.ly/blink-perf-benchmarks

Comment 4 by wangxianzhu@chromium.org, Jan 19 (3 days ago)

Cc: -f...@opera.com -wangxianzhu@chromium.org -xidac...@chromium.org -manukh@chromium.org -neis@chromium.org -eyaich@google.com -tdres...@chromium.org -dullweber@chromium.org -tom....@microsoft.com -chromium...@skia-corp.google.com.iam.gserviceaccount.com
Components: Blink>JavaScript
Owner: neis@chromium.org
Mine is a progression (though I think it might be noise).

According to pinpoint result, the regression happened after v8-r58769:

Reland^3 "[turbofan] Use feedback when reducing global loads/stores." by neis@chromium.org
https://chromium.googlesource.com/v8/v8/+/8683116e64335a99ecc403c509587410db070cd1
CSSPropertyUpdateValue: 9654 → 8404 (-1250)

Comment 5 by neis@chromium.org, Yesterday (45 hours ago)

Status: Fixed (was: Assigned)
The revert of my CL is in 73.0.3677.0

Sign in to add a comment