New issue
Advanced search Search tips

Issue 922976 link

Starred by 1 user
Status: Started
Owner:
kevers@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task



Sign in to add a comment

Confusing terminology for animation worklet ID

Project Member Reported by kevers@google.com, Jan 17 (5 days ago) 
The animation worklet contains a scope_id for uniquely identifying the worklet; however, we are moving to a design where each worklet can be associated with multiple global scopes and and use of the term scope_id becomes confusing in this context. Rename scope_id to worklet_id.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 17 (5 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3080186c7adc120461e83e799be9ed3e7c371816

commit 3080186c7adc120461e83e799be9ed3e7c371816
Author: Kevin Ellis <kevers@chromium.org>
Date: Thu Jan 17 22:26:48 2019

Rename scope_id_ in AnimationWorklet.

The variable scope_id_ is potentially misleading since a worklet can have multiple global scopes. Renamed to worklet_id_ and propagated name change.

Bug: 922976
Change-Id: If48138accb29fed40d0e749f97b461172733848e
Reviewed-on: https://chromium-review.googlesource.com/c/1417750
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Kevin Ellis <kevers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623874}
[modify] https://crrev.com/3080186c7adc120461e83e799be9ed3e7c371816/cc/animation/worklet_animation_unittest.cc
[modify] https://crrev.com/3080186c7adc120461e83e799be9ed3e7c371816/cc/trees/layer_tree_mutator.cc
[modify] https://crrev.com/3080186c7adc120461e83e799be9ed3e7c371816/cc/trees/layer_tree_mutator.h
[modify] https://crrev.com/3080186c7adc120461e83e799be9ed3e7c371816/third_party/blink/renderer/modules/animationworklet/animation_worklet.cc
[modify] https://crrev.com/3080186c7adc120461e83e799be9ed3e7c371816/third_party/blink/renderer/modules/animationworklet/animation_worklet.h
[modify] https://crrev.com/3080186c7adc120461e83e799be9ed3e7c371816/third_party/blink/renderer/modules/animationworklet/animation_worklet_proxy_client.cc
[modify] https://crrev.com/3080186c7adc120461e83e799be9ed3e7c371816/third_party/blink/renderer/modules/animationworklet/animation_worklet_proxy_client.h
[modify] https://crrev.com/3080186c7adc120461e83e799be9ed3e7c371816/third_party/blink/renderer/modules/animationworklet/worklet_animation_test.cc
[modify] https://crrev.com/3080186c7adc120461e83e799be9ed3e7c371816/third_party/blink/renderer/platform/graphics/animation_worklet_mutator.h
[modify] https://crrev.com/3080186c7adc120461e83e799be9ed3e7c371816/third_party/blink/renderer/platform/graphics/animation_worklet_mutator_dispatcher_impl.cc
[modify] https://crrev.com/3080186c7adc120461e83e799be9ed3e7c371816/third_party/blink/renderer/platform/graphics/animation_worklet_mutator_dispatcher_impl_test.cc

Comment 2 by sunyunjia@chromium.org, Jan 18 (4 days ago)

Labels: -Type-Bug Type-Task
►

Sign in to add a comment