WPT test failure - transitionstart event is not dispatched in time causing failure |
||
Issue description
The test was changed [1] to timeout after two frames and this is causing it to fail [2] in Chromium. I suspect Chrome may be taking longer to start the animation since the old test was apparently passing!
I don't believe if the spec has wording on how much delay there can be before dispatching transitionstart. So perhaps we can just increase the timeout, though I am surprise that we don't dispatch the event after two frames.
Here is the relevant change:
- await eventWatcher.wait_for('transitionstart');
+ await frameTimeout(
+ eventWatcher.wait_for('transitionstart'),
+ 2,
+ 'transitionstart'
+);
[1] https://github.com/web-platform-tests/wpt/commit/0398567bac5d9bfde928cd200ac3f52c1acfcb7e
[2] https://cs.chromium.org/chromium/src/third_party/blink/web_tests/external/wpt/css/css-transitions/CSSTransition-startTime.tentative-expected.txt
,
Jan 17
(5 days ago)
,
Jan 17
(5 days ago)
It turned out Blink has not implemented transitionstart, transitionend events (Issue 439056). So the current expectation file is correct. Given this failure expectation, the test should now pass consistently in blink. I will clean up TestExpectations file accordingly.
,
Jan 17
(5 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/62ecd8c326b32dcdd92c3f0c45b39b1d5e2a5abd commit 62ecd8c326b32dcdd92c3f0c45b39b1d5e2a5abd Author: Majid Valipour <majidvp@chromium.org> Date: Thu Jan 17 19:13:17 2019 [transitions] Update CSSTransition-startTime.tentative test expectation The CSSTransition-startTime.tentative.html test has been updates upstream to fail consistently with new timeouts. Since Blink does not implement 'transition{start,end}' events (http://crbug.com/439056) the event tests are expected to fail. The expectation file reflects this so the test should no longer timeout or be flaky. Local test (20 runs) suggests it is consistent now. Updating expectation file to reflect this. R: smcgruer@chromium.org Bug: 875622, 922970 Change-Id: Ica3999434e7126934b70dfc5bd755f8c45904d62 Reviewed-on: https://chromium-review.googlesource.com/c/1416879 Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#623785} [modify] https://crrev.com/62ecd8c326b32dcdd92c3f0c45b39b1d5e2a5abd/third_party/blink/web_tests/TestExpectations
,
Jan 18
(5 days ago)
(sheriff) external/wpt/css/css-transitions/CSSTransition-startTime.tentative.html is failing the mac bots. Samples - https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/38510 - https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/33022 I'll update the TestExpectations to suppress the red bots.
,
Jan 18
(5 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/daa5264d888eb6c73af2ea1b8898ed17d650a057 commit daa5264d888eb6c73af2ea1b8898ed17d650a057 Author: Hiroki Nakagawa <nhiroki@chromium.org> Date: Fri Jan 18 05:00:08 2019 Sheriff: Mark CSSTransition-startTime.tentative.html on Mac with [ Failure Pass ] Bug: 922970 Change-Id: Ia4c32e506ae57874cfca70bbc4cefdf197f88be9 Tbr: nhiroki@chromium.org Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/1420479 Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#624010} [modify] https://crrev.com/daa5264d888eb6c73af2ea1b8898ed17d650a057/third_party/blink/web_tests/TestExpectations
,
Jan 21
(2 days ago)
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8997ab92e68fa91597c7034783abacbb19af64f6 commit 8997ab92e68fa91597c7034783abacbb19af64f6 Author: Hiroki Nakagawa <nhiroki@chromium.org> Date: Mon Jan 21 05:13:02 2019 Sheriff: Mark CSSTransition-startTime.tentative.html as flaky This test is flaky not only on Mac but also on other environments. Change-Id: If757df60dc7bddf2d310e5c8787f52a997a0df4e Bug: 922970 Tbr: nhiroki@chromium.org Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/1424624 Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#624520} [modify] https://crrev.com/8997ab92e68fa91597c7034783abacbb19af64f6/third_party/blink/web_tests/TestExpectations |
||
►
Sign in to add a comment |
||
Comment 1 by majidvp@chromium.org
, Jan 17 (5 days ago)