New issue
Advanced search Search tips

Issue 922935 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----



Sign in to add a comment

[WPT] New failures introduced in external/wpt/css by import https://crrev.com/c/1417410

Project Member Reported by wpt-auto...@chops-service-accounts.iam.gserviceaccount.com, Jan 17 (5 days ago)

Issue description

WPT import https://crrev.com/c/1417410 introduced new failures in external/wpt/css:

List of new failures:
external/wpt/css/css-overflow/parsing/overflow-valid.html new failing tests: https://crrev.com/c/1417410/4/third_party/blink/web_tests/external/wpt/css/css-overflow/parsing/overflow-valid-expected.txt
external/wpt/css/css-overflow/parsing/line-clamp-valid.html new failing tests: https://crrev.com/c/1417410/4/third_party/blink/web_tests/external/wpt/css/css-overflow/parsing/line-clamp-valid-expected.txt
external/wpt/css/css-overflow/parsing/continue-valid.html new failing tests: https://crrev.com/c/1417410/4/third_party/blink/web_tests/external/wpt/css/css-overflow/parsing/continue-valid-expected.txt
external/wpt/css/css-overflow/parsing/block-ellipsis-valid.html new failing tests: https://crrev.com/c/1417410/4/third_party/blink/web_tests/external/wpt/css/css-overflow/parsing/block-ellipsis-valid-expected.txt
external/wpt/css/css-overflow/parsing/max-lines-valid.html new failing tests: https://crrev.com/c/1417410/4/third_party/blink/web_tests/external/wpt/css/css-overflow/parsing/max-lines-valid-expected.txt

This import contains upstream changes from 584bdfaebda852482e349f3632ac25680e64ace4 to cd94eba6eca288f9d8862ef822c5f9957c8de343:
[css-overflow] property parsing and serialization (#14910): https://github.com/web-platform-tests/wpt/commit/cd94eba6eca288f9d8862ef822c5f9957c8de343 [affecting this directory]
service worker: WPT: Add generated response tests for XHR response URL.: https://github.com/web-platform-tests/wpt/commit/938f940a19fc23db96248d843076929f9a035f2b
Fix numerical inaccuracy in background-size auto: https://github.com/web-platform-tests/wpt/commit/b01839aa6b032b70ec7ead85f6ef73bbbe5d3b12 [affecting this directory]
service worker: WPT: Add test for XHR Document's URL.: https://github.com/web-platform-tests/wpt/commit/f304798b6ec918d01d32cb3879ca714211ea8be4
Portals: Add a WindowEventHandler to the PortalActivateEvent.: https://github.com/web-platform-tests/wpt/commit/2ade7dc478df87727880d849a76ee4b5be058f63

 

Comment 1 by e...@chromium.org, Jan 17 (5 days ago)

Owner: atotic@chromium.org
Status: Assigned (was: Untriaged)
Would you mind looking into these new failures Aleks?

Comment 2 by atotic@chromium.org, Jan 21 (2 days ago)

Owner: futhark@chromium.org
These failures are caused by testing for many new properties defined 
by latest css-overflow draft spec. Failures are expected here,
style team should evaluate what to do about them. Reassigning to futhark.

/external/wpt/css/css-overflow/parsing/block-ellipsis-valid.html
https://drafts.csswg.org/css-overflow/#propdef-block-ellipsis
A new type of ellipsis? "This property allows inserting content into the last line box before a (forced or unforced) region break to indicate the continuity of truncated/interrupted content"

external/wpt/css/css-overflow/parsing/line-clamp-valid.txt
https://drafts.csswg.org/css-overflow/#propdef-line-clamp
CSS line-clamp property. Looks like an obsolete webkit CSS got redefined as a useful new spec. "Limiting Visible Lines: the line-clamp shorthand property".
Used to be "Proprietary and undocumented CSS property that will contain text to a given amount of lines when used in combination with display: -webkit-box. It will end with ellipsis when text-overflow: ellipsis is included."

external/wpt/css/css-overflow/parsing/overflow-valid.html
https://drafts.csswg.org/css-overflow/#overflow-properties
Introduces new overflow value, "clip". It is not supported by chrome or anyone else. Seems useful, it is like "hidden", but explicitly disallowing programatic scrolling. Allows overflow:clip to not establish new formatting context.

/external/wpt/css/css-overflow/parsing/max-lines-valid.html
https://drafts.csswg.org/css-overflow/#propdef-max-lines
"Forcing a Break After a Set Number of Lines: the max-lines property".

Sign in to add a comment