New issue
Advanced search Search tips

Issue 922914 link

Starred by 2 users
Status: Fixed
Owner:
perezju@chromium.org
Closed: Jan 18
Cc:
mythria@chromium.org
crouleau@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 911503



Sign in to add a comment

Provide a way to restart tracing and discard the old trace information

Project Member Reported by perezju@chromium.org, Jan 17 (5 days ago) 
In some scenarios dealing with page cache temperatures, clients want to restart tracing and throw away trace data for page runs that were only used for warming up caches. Keeping only events for the latest page run, on which metrics are computed.

A possibility is to reuse the existing tracing_controller.FlushTracing(), which already stops/restarts tracing, with an option to discard data from previous runs.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 18 (4 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/6ca0a8ed6790bc24e6306e36a94ef3b39c0ea2f3

commit 6ca0a8ed6790bc24e6306e36a94ef3b39c0ea2f3
Author: Juan Antonio Navarro Perez <perezju@chromium.org>
Date: Fri Jan 18 12:32:16 2019

[Telemetry] Discard trace data after setting page temperature

Trace data from navigations during cache temperature setting are
affecting metrics for the run that we actually want to measure.

Bug:  chromium:922914 
Bug: chromium:911503
Change-Id: I3a2457e045e46773016ed0425e9b9031c3187942
Reviewed-on: https://chromium-review.googlesource.com/c/1415653
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>

[modify] https://crrev.com/6ca0a8ed6790bc24e6306e36a94ef3b39c0ea2f3/telemetry/telemetry/core/tracing_controller.py
[modify] https://crrev.com/6ca0a8ed6790bc24e6306e36a94ef3b39c0ea2f3/telemetry/telemetry/internal/platform/tracing_controller_backend.py
[modify] https://crrev.com/6ca0a8ed6790bc24e6306e36a94ef3b39c0ea2f3/telemetry/telemetry/core/tracing_controller_unittest.py
[modify] https://crrev.com/6ca0a8ed6790bc24e6306e36a94ef3b39c0ea2f3/telemetry/telemetry/page/cache_temperature.py

Comment 2 by perezju@chromium.org, Jan 18 (4 days ago)

Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 18 (4 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f9a9ee88ea79562e8a59969005f13859ebb8a5a

commit 8f9a9ee88ea79562e8a59969005f13859ebb8a5a
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Fri Jan 18 14:05:41 2019

Roll src/third_party/catapult 8e77731b1363..6ca0a8ed6790 (1 commits)

https://chromium.googlesource.com/catapult.git/+log/8e77731b1363..6ca0a8ed6790


git log 8e77731b1363..6ca0a8ed6790 --date=short --no-merges --format='%ad %ae %s'
2019-01-18 perezju@chromium.org [Telemetry] Discard trace data after setting page temperature


Created with:
  gclient setdep -r src/third_party/catapult@6ca0a8ed6790

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:922914 ,chromium:911503
TBR=sullivan@chromium.org

Change-Id: I8824a8ad049d7670fd18b19f886077ee071977ed
Reviewed-on: https://chromium-review.googlesource.com/c/1421258
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#624103}
[modify] https://crrev.com/8f9a9ee88ea79562e8a59969005f13859ebb8a5a/DEPS
►

Sign in to add a comment