New issue
Advanced search Search tips

Issue 922902 link

Starred by 2 users
Status: Fixed
Owner:
pkasting@chromium.org
Closed: Jan 18
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Separator line is not seen between chrome chip and url.

Project Member Reported by sany...@virtusa.com, Jan 17 (5 days ago) 
Chrome Version : 73.0.3674.0 (Official Build) Revision	69010a60db037ed7b973da72c8e4171434473102-refs/branch-heads/3674@{#1} (32/64-bit)
OS : Mac(10.13.1, 10.13.6, 10.14.3) ,Win (7,8,8.1,10)

What steps will reproduce the problem?
1. Launch chrome and Navigate to 'chrome://version'.
2. Observe chrome chip in omnibox.

Actual Result   : Separator line is not seen between chrome chip and url.
Expected Result : Separator line should be seen between chrome chip and url 

This is a regression issue broken in M-73 and will soon update bisect info:
Good Build : 73.0.3673.0(Revision : 622912)
Bad Build  : 73.0.3674.0(Revision : 623508)

Note: Issue is seen for all chrome internal pages.

Kindly refer the attached screen cast for reference. 

Thank you..!
Actual Result.mov
902 KB View Download
Expected Result.mov
1.2 MB View Download

Comment 1 by sany...@virtusa.com, Jan 17 (5 days ago)

Labels: hasbisect-per-revision OS-Linux
Owner: pkasting@chromium.org
Status: Assigned (was: Unconfirmed)
Update:

You are probably looking for a change made after 623029 (known good), but no later than 623030 (first known bad).

CHANGE-LOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/9eb19884ede27f7080c79b9ea596d48bcdd96bf3..40f742b90554fb75744a896eabf627fcdc657de5

Suspect: https://chromium.googlesource.com/chromium/src/+/40f742b90554fb75744a896eabf627fcdc657de5

@Peter: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note: Issue is also reproducible on Linux (14.04 LTS)
Thank you..!

Comment 2 by pkasting@chromium.org, Jan 18 (5 days ago)

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 18 (5 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/930a0f786355a7ce53129de4f647ab9a3f8a212a

commit 930a0f786355a7ce53129de4f647ab9a3f8a212a
Author: Peter Kasting <pkasting@chromium.org>
Date: Fri Jan 18 03:38:00 2019

Compute separator color against correct background color.

The existing code was mistakenly still using the text color when I'd intended to
change it to the background color.  Fix that.

Along the way, I discovered that the omnibox theme uses different background
colors than our spec claims.  Adjusted the alpha value slightly based on this.
As a result of the different background colors and the new alpha, the actual
contrast ratios of this patch are normal = 2.44, incognito = 3.67, which is
nearly-identical to the originally-landed-in-2016 design's 2.44/3.69.

Bug:  922902 
Change-Id: If9ab481b87670f9db4ad649897f4d12c0cfa04be
Reviewed-on: https://chromium-review.googlesource.com/c/1419898
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623993}
[modify] https://crrev.com/930a0f786355a7ce53129de4f647ab9a3f8a212a/chrome/browser/ui/views/location_bar/icon_label_bubble_view.cc
[modify] https://crrev.com/930a0f786355a7ce53129de4f647ab9a3f8a212a/chrome/browser/ui/views/location_bar/icon_label_bubble_view.h

Comment 4 by pkasting@chromium.org, Jan 18 (4 days ago)

Status: Fixed (was: Started)
►

Sign in to add a comment