New issue
Advanced search Search tips

Issue 922889 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

V8 DEPS roll broken: https://crrev.com/c/1416608

Project Member Reported by machenbach@google.com, Jan 17 (5 days ago)

Issue description

Comment 1 by machenbach@google.com, Jan 17 (5 days ago)

Cc: staphany@chromium.org
Owner: machenb...@chromium.org
Status: Started (was: Untriaged)
Looks like the google test roll was reverted and we need to revert our port as well...
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 17 (5 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/7b01fe76d1a21f90ec6a315aaa362f668ede45c3

commit 7b01fe76d1a21f90ec6a315aaa362f668ede45c3
Author: Michael Achenbach <machenbach@chromium.org>
Date: Thu Jan 17 08:14:47 2019

Update V8 DEPS.

Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/7a1aacd..de8bef4

Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/78448d9..a9729f3

Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/e229a0e..d1dba64

Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/933e5df..879ac09

Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/a9c5056..9f413ce

This also ports:
https://crrev.com/c/1415130

TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org

Bug:  chromium:922889 
Change-Id: Ibf674eeefb82f9feb210107d6081c489cfba48db
Reviewed-on: https://chromium-review.googlesource.com/c/1416608
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#58868}
[modify] https://crrev.com/7b01fe76d1a21f90ec6a315aaa362f668ede45c3/DEPS
[modify] https://crrev.com/7b01fe76d1a21f90ec6a315aaa362f668ede45c3/third_party/googletest/BUILD.gn
[modify] https://crrev.com/7b01fe76d1a21f90ec6a315aaa362f668ede45c3/third_party/googletest/README.chromium

Comment 3 by machenbach@google.com, Jan 17 (5 days ago)

Status: Fixed (was: Started)
Will probably break again on reland.

Sign in to add a comment