Auto Picture-in-Picture should apply only to playing video |
||
Issue descriptionFor now, we check that video has metadata loaded. This is not enough in the context Auto Picture-in-Picture. We should make sure Auto Picture-in-Picture applies only to video that are "potentially playing" as discussed with UX See https://html.spec.whatwg.org/multipage/media.html#potentially-playing
,
Yesterday
(43 hours ago)
It works well with video that are not paused when hidden. Sadly when video is paused when hidden, even though playback is resumed when video enters Picture-in-Picture, it is not a candidate to enter Auto Picture-in-Picture as video is not paused since https://chromium-review.googlesource.com/c/chromium/src/+/1421100 mlamouri@ What do you think of this check for entering Auto Picture-in-Picture? (!AutoPictureInPictureElement()->paused() || AutoPictureInPictureElement()->PausedWhenHidden())
,
Yesterday
(40 hours ago)
,
Today
(12 hours ago)
Hmm, WebMediaPlayerImpl::PauseVideoIfNeeded() should result in paused() being true, is that not the case? See: https://cs.chromium.org/chromium/src/media/blink/webmediaplayer_impl.cc?l=3365 That generates an OnPause which notifies the element. |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Jan 18 (4 days ago)