Just a note for sheriffs or anyone else looking at this. I would strongly prefer that we avoid reverting here. The landed CL is correct as-is and likely reveals a timing problem within these tests.

I'll try to repair the tests ASAP. Also adding jam@ for Network Service input.

 Issue 922877  has been merged into this issue.

*/NetworkContextConfigurationProxyOnStartBrowserTest.TestInitialProxyConfig/* tests are also affected

Disabling flaky tests in the meantime; removing from sheriff queue. Thanks, Ken!

Not sure what's going on here - we seem to be flushing the mojo pipe correctly.  We seem to be getting ERR_NETWORK_CHANGED (Do we return that on network errors?).

*network errors == proxy changes.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5fe5e42823d385819fdc6f9dc57d4df8780d17c2

commit 5fe5e42823d385819fdc6f9dc57d4df8780d17c2
Author: Ian Clelland <iclelland@chromium.org>
Date: Thu Jan 17 17:12:20 2019

Disable two flaky NetworkContextConfiguration browser tests

TBR: mmenke@chromium.org
Bug: 922876
Change-Id: I7aa180a67d2d8cae122b4472df80659914912b81
Reviewed-on: https://chromium-review.googlesource.com/c/1417756
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Auto-Submit: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623727}
[modify] https://crrev.com/5fe5e42823d385819fdc6f9dc57d4df8780d17c2/chrome/browser/net/network_context_configuration_browsertest.cc

The fact that NetworkContextConfigurationProxyOnStartBrowserTest is failing indicates to me that this is more than just a test issue - that starts up Chrome an checks proxy configuration.  So either we're not saving the old config, or something's going wrong with loading the new one, I assume.