New issue
Advanced search Search tips

Issue 922859 link

Starred by 2 users

Issue metadata

Status: Unconfirmed
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Zero width joiner causes invalid filename error in downloads API

Reported by eigh...@gmail.com, Jan 17 (6 days ago)

Issue description

UserAgent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3538.110 Safari/537.36

Steps to reproduce the problem:
1. Clone https://github.com/eight04/webextension-test/tree/chrome-emoji-filename
2. Load as an unpacked extension. There should be no need to install npm/dependencies.
3. Click the browser action button.

What is the expected behavior?
The browser should save a text file in the download folder. In Firefox you get:
https://i.imgur.com/KjTnkBP.png

What went wrong?
`downloads.download` failed with an "Invalid filename" error:
https://i.imgur.com/gjOjH96.png

Did this work before? N/A 

Does this work in other browsers? Yes

Chrome version: 70.0.3538.110  Channel: n/a
OS Version: 6.1 (Windows 7, Windows Server 2008 R2)
Flash Version: Shockwave Flash 32.0 r0
 

Comment 1 by dtapu...@chromium.org, Jan 17 (5 days ago)

Components: UI>Browser>Downloads

Comment 2 by vamshi.kommuri@chromium.org, Jan 17 (5 days ago)

Labels: Needs-Milestone

Comment 3 by woxxom@gmail.com, Jan 17 (5 days ago)

Bisected to r314041 = 92a354fca8d118ad1be38612f85aa71a9a25303b = crrev.com/869823003 by asanka@chromium.org
"Update ReplaceIllegalCharactersInPath to handle quirks in HFS+ and VFAT"
Landed in 42.0.2293.0

Comment 4 by woxxom@gmail.com, Jan 17 (5 days ago)

The change should have been limited to HFS+ and VFAT file systems but was erroneously applied to NTFS.
In NTFS this symbol is valid for file names.

Note, Chrome can still write into a file that has that symbol in the name:
1. select and copy 👁‍🗨.txt
2. invoke the save dialog (Ctrl-S or right-click the page then "Save as")
3. paste the copied name and confirm the dialog

Sign in to add a comment